Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update deploy_to_pypi_prod workflow dependencies #68

Merged

Conversation

mnbf9rca
Copy link
Owner

@mnbf9rca mnbf9rca commented Jul 23, 2024

Summary by Sourcery

This pull request updates the deploy_to_pypi_prod workflow by removing its dependency on the deploy_to_pypi_test job, streamlining the deployment process.

  • Deployment:
    • Updated the deploy_to_pypi_prod workflow to remove the dependency on the deploy_to_pypi_test job.

Copy link

sourcery-ai bot commented Jul 23, 2024

Reviewer's Guide by Sourcery

This pull request updates the 'deploy_to_pypi_prod' workflow by removing the dependency on the 'deploy_to_pypi_test' job. This change simplifies the deployment process by ensuring that the production deployment only depends on the 'build_artifacts' job.


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@mnbf9rca mnbf9rca merged commit d3bd124 into main Jul 23, 2024
5 checks passed
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mnbf9rca - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you provide more context on why the 'deploy_to_pypi_test' step is being removed? We're concerned about potential risks of deploying directly to production without this intermediate step. Are there other safeguards in place to ensure package quality and stability?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@mnbf9rca mnbf9rca deleted the fix/allow-push-to-pypi-without-going-through-pypi-test-first branch September 10, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant