Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with OptiX 8 #391

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Compatibility with OptiX 8 #391

merged 2 commits into from
Oct 18, 2023

Conversation

Mike-Leo-Smith
Copy link
Contributor

As per the release notes of OptiX 8, some APIs have been changed, which break the compilation:

  1. The flag OPTIX_EXCEPTION_FLAG_DEBUG has been removed;
  2. OptixDenoiserAlphaMode was moved from OptixDenoiserParams to OptixDenoiserOptions.

This PR adds version guards for these changes to make PBRT-v4 compatible with OptiX 8.

@mmp
Copy link
Owner

mmp commented Oct 18, 2023

Thanks!!

@mmp mmp merged commit ba6b095 into mmp:master Oct 18, 2023
18 of 42 checks passed
@mmp mmp mentioned this pull request Oct 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mike-Leo-Smith @mmp