🐛 Use URL instead of regex for shadow-db name #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connectionString is a URL, so it should be treated as such. regex didn't handle more complex cases (such as "-" in the name of database). And while it is possible to tweak regex for greater compatibility, using actual URL-object guarantees proper result in ALL cases. mmkal#434
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This looks good to me. I'm on parental leave at the moment but will try to get this merged + published in the next few days. |
|
@mmkal (friendly ping) |
|
Thanks for the nudge! I published a prerelease for this: 0.2.7-14 Could you try and see if that works? If so I'll merge. |
|
@mmkal yes, seems to work just fine 👍 |
|
@mmkal can you make a proper release pls? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connectionString is a URL, so it should be treated as such. regex didn't
handle more complex cases (such as "-" in the name of database).
And while it is possible to tweak regex for greater compatibility, using
actual URL-object guarantees proper result in ALL cases.
#434