Media Provider: Un-mark as internal so it can be optionally disabled #1090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Media provider looks for assets for your games, but based on the other issue, and that none of the provider are turned on on your screenshot, I assume all your games already have those set manually. It does sound reasonable to disable the Media provider in that case. Thank you for your contribution! |
|
I was planning to update the provider name, but got a bit delayed... I'll just merge this first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alongside some Android startup improvements in #1089, I found that the Media processing was taking a long time during Pegasus startup.
For example, on an Anbernic RG405M device with 40k+ screenshots, it's taking over 32s:
Guided by a comment in #839 (comment), I tried disabling the Media provider, and it cut out this delay entirely.
After I did this, I reviewed my theme and could not find any side-effects -- all screenshots were continuing to load OK. I reviewed its code, and could not find other obvious places its output would be used, so I must be missing something. Is there something the MediaProvider is doing that I'm breaking by disabling it?
Anyways, for my use-case, it seems like avoiding the MediaProvider is beneficial (faster startup) and causes no side-effects.
This PR un-marks the
MediaProvideras internal, so that users can optionally disable it in via just the UI, instead of building a custom APK.