Merge pull request #741 from thcgit/master

Escape spaces for runner path in NodeTestExecutionProvider.
mmanela · Jan 7, 2019 · e7a8889 · e7a8889
2 parents 40a551f + bfd8fa3
commit e7a8889
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Chutzpah/ChutzpahJSRunners/Chrome/chutzpahRunner.js b/Chutzpah/ChutzpahJSRunners/Chrome/chutzpahRunner.js
@@ -234,7 +234,7 @@ module.exports.runner = async (onInitialized, onPageLoaded, isFrameworkLoaded, o
     try {
         let chromeExecutable = null;
 
-        if (chromePath == null) {
+        if (!chromePath) {
             const chromePaths = getChromePaths();
             if (chromePaths.length <= 0) {
                 debugLog("Could not find chrome paths");

diff --git a/Chutzpah/ExecutionProviders/NodeTestExecutionProvider.cs b/Chutzpah/ExecutionProviders/NodeTestExecutionProvider.cs
@@ -112,7 +112,7 @@ private static string BuildRunnerArgs(TestOptions options, TestContext context,
             string runnerArgs;
             var testModeStr = testExecutionMode.ToString().ToLowerInvariant();
             var timeout = context.TestFileSettings.TestFileTimeout ?? options.TestFileTimeoutMilliseconds ?? Constants.DefaultTestFileTimeout;
-            runnerArgs = string.Format("{0} {1} {2} {3} {4} {5} {6} {7}",
+            runnerArgs = string.Format("\"{0}\" {1} {2} {3} {4} {5} {6} {7}",
                                         runnerPath,
                                         fileUrl,
                                         testModeStr,