Merge branch 'develop'

mmahacek · Dec 21, 2023 · 7d01ee3 · 7d01ee3
2 parents bea15bf + 244b230
commit 7d01ee3
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,12 @@
 # Changelog
 
 
+## [0.1.2] 2023-12-21
+
+### Breaking Change
+
+* Updated `ApiPayloadError` exception to trigger when API returns HTTP 400+.
+
 ## [0.1.1] 2023-12-21
 
 ### Breaking Change

diff --git a/pyonms/__init__.py b/pyonms/__init__.py
@@ -7,7 +7,7 @@
 .. include:: ../README.md
 """
 
-__version__ = "0.1.1"
+__version__ = "0.1.2"
 
 from multiprocessing import current_process
 from urllib.parse import urlsplit

diff --git a/pyonms/dao/base.py b/pyonms/dao/base.py
@@ -116,7 +116,7 @@ def _get(
                 return response.json()
         elif response.status_code == 401:
             raise AuthenticationError
-        elif response.status_code >= 500:
+        elif response.status_code >= 400:
             raise ApiPayloadError(message=response.text)
         return {}
 
@@ -144,7 +144,7 @@ def _get_v1(
                 else:
                     xml_data = pyonms.utils.convert_xml(response.text)
                     return self._convert_v1_to_v2(endpoint, xml_data)
-        elif response.status_code >= 500:
+        elif response.status_code >= 400:
             raise ApiPayloadError(message=response.text)
         return {}
 
@@ -188,7 +188,7 @@ def _post(
                 verify=self.verify_ssl,
                 timeout=self.timeout,
             )
-        if response.status_code >= 500:
+        if response.status_code >= 400:
             raise ApiPayloadError(message=response.text)
         return response
 
@@ -233,7 +233,7 @@ def _put(
                 verify=self.verify_ssl,
                 timeout=self.timeout,
             )
-        if response.status_code >= 500:
+        if response.status_code >= 400:
             raise ApiPayloadError(message=response.text)
         return response
 
@@ -267,6 +267,6 @@ def _delete(self, url: str, headers: dict = None, params: dict = None) -> dict:
             verify=self.verify_ssl,
             timeout=self.timeout,
         )
-        if response.status_code >= 500:
+        if response.status_code >= 400:
             raise ApiPayloadError(message=response.text)
         return {}