R7 with no custom length shouldn't fail (#1120)

mlverse · Nov 8, 2023 · babc1fe · babc1fe
1 parent fe44f6b
commit babc1fe
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/R/R7.R b/R/R7.R
@@ -132,7 +132,7 @@ length.R7 <- function(x) {
   tryCatch(
     x$length(), 
     error = function(err) {
-      cli::cli_abort("{.val length} is not support for objects with class {.cls {class(x)}}")
+      1 # when no custom length method is implemented, we return 1.
     }
   )
 }
diff --git a/tests/testthat/test-device.R b/tests/testthat/test-device.R
@@ -83,3 +83,8 @@ test_that("printer works", {
     print(torch_device("cpu"))
   })
 })
+
+test_that("can query device length", {
+  device <- torch_device("cpu")
+  expect_equal(length(device), 1)
+})