Support for a special kind of obj file (like igl saved). #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge the newest version
mlund
reviewed
Jan 4, 2025
| @@ -1063,6 +1154,10 @@ bool Voronoi3D::validDeletionSetNew(Array<int> &deletable, Array<bool> &flags, | |||
|
|
|||
| for (int j = 0; j < MAGICK_NUM && ok; j++) { | |||
| int u = v->n[j]; | |||
| if (u < 0 || u >= vertices.getSize()) { | |||
There was a problem hiding this comment.
I think there's an indentation issue here. Would you mind running clang-format on the changes?
mlund
reviewed
Jan 4, 2025
| @@ -1225,11 +1324,19 @@ bool Voronoi3D::getCloserForming(int *newForming, float *newDistance, | |||
| for (int i = 0; i < numVerts; i++) { | |||
| // get vertex | |||
| int vI = form->vertices.index(i); | |||
mlund
reviewed
Jan 4, 2025
| @@ -667,8 +717,16 @@ void Voronoi3D::remap(Array<int> &list, int oldV, int newV, int sI) const { | |||
| } | |||
|
|
|||
| void Voronoi3D::deleteVertex(int dI, Array<int> &deletable) { | |||
| if (dI < 0 || dI >= deletable.getSize()) { | |||
| OUTPUTINFO("Invalid deletable index in deleteVertex: %d \n", dI); | |||
mlund
reviewed
Jan 4, 2025
| @@ -364,6 +367,10 @@ bool Voronoi3D::validNewVertices(const Array<int> &deletable, | |||
|
|
|||
| for (int j = 0; j < MAGICK_NUM; j++) { | |||
| int u = v->n[j]; | |||
| if (u < 0 || u >= vertices.getSize()) { | |||
mlund
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for a special kind of obj file
Fix: small area sampling consuming too much time
Fix: invalid access of memory
I