Use new configuration values for telling if indentation reporting is turned on. Closes #10. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turned on. Closes #10.
|
It would be great to maintain backward-compatibility - it should be
pretty straightforward - most likley the old version would throw some
exception - so you can catch that exception and revert in this case to
old logic.
…On 11/28/2022 3:42 PM, Quin wrote:
This works from my testing, although am pretty sure it'll break on
older versions of NVDA. I'm not sure how doing stuff based on API
versions works in add-ons, but I imagine its not that hard, if you're
interested in maintaining backward compatibility. I can most likely
make the necessary changes, just didn't yet, as I'm not sure if it's
wanted.
------------------------------------------------------------------------
You can view, comment on, or merge this pull request online at:
#11
Commit Summary
* ddf5421
<ddf5421>
Use new configuration values for telling if indentation reporting
is turned on. Closes #10.
File Changes
(1 file <https://github.com/mltony/nvda-indent-nav/pull/11/files>)
* *M* addon/globalPlugins/indent_nav.py
<https://github.com/mltony/nvda-indent-nav/pull/11/files#diff-fba13cacb2393d4d1ae7b12609a918a16b2d8b0d877b75ff6c72eaec5d592dce>
(3)
Patch Links:
* https://github.com/mltony/nvda-indent-nav/pull/11.patch
* https://github.com/mltony/nvda-indent-nav/pull/11.diff
—
Reply to this email directly, view it on GitHub
<#11>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIJRDHAQD62PF7JDT6ZZZXLWKU7PNANCNFSM6AAAAAASN36B24>.
You are receiving this because you are subscribed to this
thread.Message ID: ***@***.***>
|
|
Hi, backwards compatibility should now be there :) |
|
Great; I'll review your PR on the weekend. Thanks for working on this!
…On 11/29/2022 8:11 AM, Quin wrote:
Hi, backwards compatibility should now be there :)
—
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIJRDHBBURSHB5PE2QAZGKLWKYTJPANCNFSM6AAAAAASN36B24>.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works from my testing, although am pretty sure it'll break on older versions of NVDA. I'm not sure how doing stuff based on API versions works in add-ons, but I imagine its not that hard, if you're interested in maintaining backward compatibility. I can most likely make the necessary changes, just didn't yet, as I'm not sure if it's wanted.