Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change wandb env var to properly disable at start of testing #94

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

joeloskarsson
Copy link
Collaborator

@joeloskarsson joeloskarsson commented Dec 6, 2024

Describe your changes

Tests are not working properly as wandb without any user logged in are making them crash. This should not happen, since we disable WANDB with env var when running the tests, but that variable is wrong. This is an attempt to fix that, to make sure wandb is disabled when running tests.

Issue Link

None

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📖 Documentation (Addition or improvements to documentation)

Checklist before requesting a review

  • My branch is up-to-date with the target branch - if not update your fork with the changes from the target branch (use pull with --rebase option if possible).
  • I have performed a self-review of my code
  • For any new/modified functions/classes I have added docstrings that clearly describe its purpose, expected inputs and returned values
  • I have placed in-line comments to clarify the intent of any hard-to-understand passages of my code
  • I have updated the README to cover introduced code changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have given the PR a name that clearly describes the change, written in imperative form (context).
  • I have requested a reviewer and an assignee (assignee is responsible for merging). This applies only if you have write access to the repo, otherwise feel free to tag a maintainer to add a reviewer and assignee.

Checklist for reviewers

Each PR comes with its own improvements and flaws. The reviewer should check the following:

  • the code is readable
  • the code is well tested
  • the code is documented (including return types and parameters)
  • the code is easy to maintain

Author checklist after completed review

  • I have added a line to the CHANGELOG describing this change, in a section
    reflecting type of change (add section where missing):
    • added: when you have added new functionality
    • changed: when default behaviour of the code has been changed
    • fixes: when your contribution fixes a bug

Checklist for assignee

  • PR is up to date with the base branch
  • the tests pass
  • author has added an entry to the changelog (and designated the change as added, changed or fixed)
  • Once the PR is ready to be merged, squash commits and merge the PR.

@joeloskarsson joeloskarsson self-assigned this Dec 6, 2024
@joeloskarsson
Copy link
Collaborator Author

Seems to be working 😄

@khintz
Copy link
Contributor

khintz commented Dec 6, 2024

Do we want an entry to the changelog? Even though it is a tiny change I always prefer that.

@joeloskarsson
Copy link
Collaborator Author

Yes, already on it 😀 Just wanted to see that it worked first.

Copy link
Contributor

@khintz khintz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving under the assumption all tests will pass again.

@joeloskarsson joeloskarsson merged commit 1a12826 into mllam:main Dec 6, 2024
8 checks passed
@joeloskarsson joeloskarsson deleted the disable_wandb_in_tests branch December 6, 2024 15:04
@joeloskarsson joeloskarsson mentioned this pull request Dec 6, 2024
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants