Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add package build and upload to pypi for releases into ci/cd setup #71

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add package build and upload to pypi for releases into ci/cd setup #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74470dc
add package build and upload to pypi in cicd
leifdenby Aug 20, 2024
6fb2a91
add reference to README
leifdenby Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/ci-pypi-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: package-release

on:
workflow_dispatch:
pull_request:
push:
branches:
- main
release:
types:
- published

jobs:
build:
name: build and upload release to pypi
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-python@v2
Comment on lines +18 to +19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the usual comments ;)

Suggested change
- uses: actions/checkout@v2
- uses: actions/setup-python@v2
- uses: actions/checkout@v4
- uses: actions/setup-python@v5

- uses: casperdcl/deploy-pypi@v2
Copy link
Contributor

@observingClouds observingClouds Feb 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not get away with the more common github action pypi-publish? pypi-publish has a lot more maintainers and a larger community making it more likely to provide updates. Alternative we could also use the publish action of some package manager like pdm publish?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, yes we can, I am just used to using this action and I am bit loathe change this since I won't know until we create the release whether I have made a typo. Unless you have already used pypi-publish and have an example I can copy? ☺️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understand. I recently have used this pdm publish

with:
password: ${{ secrets.PYPI_TOKEN }}
pip: wheel -w dist/ --no-deps .
upload: ${{ github.event_name == 'release' && github.event.action == 'published' }}
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ authors = [
{name = "Simon Adamov", email = "[email protected]"},
{name = "Leif Denby", email = "[email protected]"},
]
readme = "README.md"

# PEP 621 project metadata
# See https://www.python.org/dev/peps/pep-0621/
Expand Down
Loading