Three minor bugfixes for data_config.yaml workflow

[sadamov]

Summary

#31 introduced three minor bugs that are fixed with this PR:

• coords_projection is a cached_property and as such is not callable (removed ())
• r"" strings are not required in units of data_config.yaml
• dictionaries cannot be passed as argsparse, rather JSON strings. This bug is related to the flag var_leads_metrics_watch

[leifdenby]

While you are doing this I thought of something else with the config: Shouldn't num_forcing_features be derived as the length of the dataset.var_names list in the config https://github.com/mllam/neural-lam/blob/main/neural_lam/data_config.yaml#L57? I mean rather than being defined separately.

[sadamov]

Hmm, the dataset.var_names are of the state not of the forcings though.
In the future when our yaml file covers state,forcings and boundaries I suggest something along these lines
https://github.com/mllam/neural-lam/blob/feature_dataset_yaml/neural_lam/data_config.yaml

      self.grid_dim = (
            2 * self.config_loader.num_data_vars("state")
            + grid_static_dim
            + self.config_loader.num_data_vars("forcing")
            * self.config_loader.forcing.window
        )

Note, that currently the forcings are calculate in parts in the dataset and in otherparts loaded from .npy files.

[leifdenby]

Hmm, the dataset.var_names are of the state not of the forcings though.

Ah yes, of course you're right! But but isn't num_forcing_features == 16 too large then? I thought the forcing features were only radiation etc.

Also, I really like your suggestion about introducing a num_data_vars representation somewhere. Should I start a separate issue for this so we can discuss it in more detail?

[sadamov]

the forcings should be GRID_FORCING_DIM = 5 * 3 + 1 # 5 feat. for 3 time-step window + 1 batch-static (from original constants.py)

=16

1. land sea mask (batch-static)
2. top of atmosphere radiation (window)
3. sin hour of day (window)
4. cos hour of day (window)
5. sin day in year (window)
6. cos day in year (window)

[sadamov]

num_data_vars is already implemented in the Config class:

neural-lam/neural_lam/config.py

Line 51 in 5b71be3

def num_data_vars(self):

[joeloskarsson]

Good fixes, just a small thing about the dict argument.

[joeloskarsson]

The coords_projection problem was fixed by merging #17, so merged main in here so we don't see that change.

[joeloskarsson]

All good now, tested and it works!

[joeloskarsson]

Did not add explicitly to changelog as these are only fixes to #23