-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize state diff stats in mdp datastore. Change variable name. #122
Conversation
I think this is ready for review. One question I have is whether I should keep both the normalized and non-normalized state_diff stats (this is what I've done), or if I should just remove them entirely. |
Also, this goes in v0.4.0, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See small comments above (forgot to make them part of review)
Done 👍 care to have a final look and then I'll merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! lgtm
Describe your changes
This PR fixes a bug where the
MDPDatastore
returns non-normalizedstate_diff_mean
andstd
, whileNpyFilesDatastoreMEPS
returns the normalized versions. See the linked issue for a discussion on this.The fix updates the
MDPDatastore
to returnstate_diff_std_standardized
andstate_diff_mean_standardized
in addition to the existing non-standardized versions. TheNpyFilesDatastoreMEPS
already only returned the standardized versions, so here the variable name has just been changed.Also updated where
get_standardization_dataarray
is called to get the standardized versions.Issue Link
Closes #112
Type of change
Checklist before requesting a review
pull
with--rebase
option if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee