-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix how torch version is derived in ci/cd and clean up github actions #115
Merged
leifdenby
merged 16 commits into
mllam:main
from
leifdenby:maint/cicd-torch-pinning-and-refactor
Feb 6, 2025
Merged
Fix how torch version is derived in ci/cd and clean up github actions #115
leifdenby
merged 16 commits into
mllam:main
from
leifdenby:maint/cicd-torch-pinning-and-refactor
Feb 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hauke Schulz <[email protected]>
Co-authored-by: Hauke Schulz <[email protected]>
Co-authored-by: Hauke Schulz <[email protected]>
Thanks @observingClouds could you check this again? If you are happy then I will merge :) |
observingClouds
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the changes! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes to ci/cd setup to ensure that correct torch version is installed when testing with cpu/gpu and pdm/pip. And refactor to have single github actions script (rather than four as before).
Issue Link
#114
Type of change
Checklist before requesting a review
pull
with--rebase
option if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee