Merge pull request aerospike#127 from citrusleaf/CLIENT-675

Use heap allocation for get_many requests > 20K records
mlicheng · Feb 17, 2016 · 23a1389 · 23a1389
2 parents 1b38c18 + 73c4cf2
commit 23a1389
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/src/main/client/get_many.c b/src/main/client/get_many.c
@@ -29,6 +29,8 @@
 #include "exceptions.h"
 #include "policy.h"
 
+#define MAX_STACK_ALLOCATION 20000
+
 typedef struct {
 	PyObject * py_recs;
 	AerospikeClient * client;
@@ -244,7 +246,11 @@ static PyObject * batch_get_aerospike_batch_read(as_error *err, AerospikeClient
 		Py_ssize_t size = PyList_Size(py_keys);
 
         py_recs = PyList_New(size);
-        as_batch_read_inita(&records, size);
+        if (size > MAX_STACK_ALLOCATION) {
+        	as_batch_read_init(&records, size);
+        } else {
+        	as_batch_read_inita(&records, size);
+        }
 
         // Batch object initialised
         batch_initialised = true;
@@ -272,7 +278,11 @@ static PyObject * batch_get_aerospike_batch_read(as_error *err, AerospikeClient
 		Py_ssize_t size = PyTuple_Size(py_keys);
 
         py_recs = PyList_New(size);
-        as_batch_read_inita(&records, size);
+        if (size > MAX_STACK_ALLOCATION) {
+        	as_batch_read_init(&records, size);
+        } else {
+        	as_batch_read_inita(&records, size);
+        }
         // Batch object initialised
         batch_initialised = true;