Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Full ROnline Journals records do not display from lack of indexing_date. #520

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

erinesullivan
Copy link
Contributor

Overview

Viewing a full Online Journal record does not display because of this error:

Uncaught TypeError: Cannot destructure property 'name' of 'At(...)' as it is undefined.
    at index.js:204:23
    at da (index.js:203:23)

This was because findWhere(record.fields, { uid: 'indexing_date' }) would return undefined. An empty object has been added as a backup.

Anything else?

The inDatastore check has been removed. It will now display on any record where the field exists.

Testing

  • Make sure the PR is consistent in these browsers:
    • Chrome
    • Firefox
    • Safari
    • Edge
  • Run accessibility tests:
    • WAVE
    • ARC Toolkit
    • axe DevTools
  • Check a full Online Journal record and see if you can view it.
    • Check any other record to see if they still display.

…the datastore. Also adding blank object as backup.
@erinesullivan erinesullivan self-assigned this Jan 28, 2025
@erinesullivan erinesullivan merged commit 7e564a3 into master Jan 28, 2025
7 checks passed
@erinesullivan erinesullivan deleted the bug-onlinejournals-full-record-not-displaying branch January 28, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant