Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛💄 safari css filter #67

Merged
merged 2 commits into from
Jul 31, 2023
Merged

🐛💄 safari css filter #67

merged 2 commits into from
Jul 31, 2023

Conversation

danton267
Copy link
Collaborator

Adds filter CSS support for Safari browsers.

@danton267 danton267 linked an issue Jul 31, 2023 that may be closed by this pull request
Brightness and contrast settings don't work on safari #60
Closed
@github-actions
Copy link

github-actions bot commented Jul 31, 2023 •
edited
Loading

Staging application has been deployed and is available at: https://dash5-services.plotly.host/ml-exchange-staging
Production app name: ml-exchange
Current branch name: fix-safari-css-filter
Commit: a7dd460

MinaMirz
MinaMirz approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@MinaMirz MinaMirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on Safari and Chrome on my side 💃

@danton267
Copy link
Collaborator Author

Tested and ensured it works on Safari, Chrome, Brave, MS Edge, and Firefox.

@danton267 danton267 merged commit 1e3b2a5 into main Jul 31, 2023
4 checks passed
@danton267 danton267 deleted the fix-safari-css-filter branch July 31, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinaMirz MinaMirz MinaMirz approved these changes

@tamidodo tamidodo Awaiting requested review from tamidodo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Brightness and contrast settings don't work on safari
2 participants
@danton267 @MinaMirz