Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation exporting hannah #56

Closed
wants to merge 21 commits into from

Conversation

hannahker
Copy link
Collaborator

@hannahker hannahker commented Jul 24, 2023

  • Pulls in updates from main -- notably @tamidodo's work on the annotation class generator
  • Saves label information for the custom annotation classes, rather than using the old hard-coded defaults
  • Assumes that all image slices are the same shape. This assumption holds with the structure of the multidimensional array stored on LBL's Tiled server (the old code for this threw an error since the data structure is slightly different than what's set up with the local Tiled server)

@github-actions
Copy link

github-actions bot commented Jul 24, 2023

Staging application has been deployed and is available at: https://dash5-services.plotly.host/ml-exchange-staging
Production app name: ml-exchange
Current branch name: annotation-exporting-hannah
Commit: 905f7a2

@hannahker hannahker requested a review from danton267 July 24, 2023 23:17
@hannahker hannahker mentioned this pull request Jul 24, 2023
@@ -145,7 +140,7 @@ def set_annotation_class(self, annotation):
if annotation["line"]["color"] in map_color_to_class:
self.annotation_class = map_color_to_class[annotation["line"]["color"]]
else:
self.annotation_class = 99
self.annotation_class = 99 # todo: change this method to work with @tammy's #57 PR - new color picker features
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since map_color_to_class won't work anymore due to the dynamic annotations feature, we need to wait for #57 where a feature that stores colors and class names of the annotations will be added.
We will then take class names for every annotation, and add it appropriately.

Until then all classes will be placeholder value 99

@danton267
Copy link
Collaborator

Looks good to me the only thing to note is the comment about the annotation classes which rely on new features inside #57 .

TLDR: currently all classes will default to one class until #57 is finished, after which we can take the data about corresponding annotation classes and use it here. Will make a PR for that as soon as we can

@hannahker
Copy link
Collaborator Author

Closing in favour of #58

@hannahker hannahker closed this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants