-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotation exporting hannah #56
Conversation
🚸 preserve zoom and pan on image change
Center layout
…s-for-local-tiled-server 📝 Update README.md
Update annotation UI
Staging application has been deployed and is available at: https://dash5-services.plotly.host/ml-exchange-staging |
utils/annotations.py
Outdated
@@ -145,7 +140,7 @@ def set_annotation_class(self, annotation): | |||
if annotation["line"]["color"] in map_color_to_class: | |||
self.annotation_class = map_color_to_class[annotation["line"]["color"]] | |||
else: | |||
self.annotation_class = 99 | |||
self.annotation_class = 99 # todo: change this method to work with @tammy's #57 PR - new color picker features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since map_color_to_class won't work anymore due to the dynamic annotations feature, we need to wait for #57 where a feature that stores colors and class names of the annotations will be added.
We will then take class names for every annotation, and add it appropriately.
Until then all classes will be placeholder value 99
Looks good to me the only thing to note is the comment about the annotation classes which rely on new features inside #57 . TLDR: currently all classes will default to one class until #57 is finished, after which we can take the data about corresponding annotation classes and use it here. Will make a PR for that as soon as we can |
Closing in favour of #58 |
main
-- notably @tamidodo's work on the annotation class generator