✨ Disable controls while loading #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Staging application has been deployed and is available at: https://dash5-services.plotly.host/ml-exchange-staging |
|
@danton267 this is functional but I'd advocate for the solution in #53 since it's fewer LOC and more maintainable! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables controls on
Something to think about:
if the UX is a problem, we remove, let controls be usable while images are loading, and "cache" the changed controls.
Then every time a figure finishes plotting, look at the cache, and see if anything has changed since the plot creation event, if yes patch it => no constant enabling/disabling of controls, and having to wait for the user to be able to interact with them.