Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐳 Add action to publish Docker image #45

Merged
merged 5 commits into from
Jul 31, 2023
Merged

Conversation

Wiebke
Copy link
Member

@Wiebke Wiebke commented Jul 14, 2023

Makes progress towards resolving #4 for deployment at Spin with Spin being able to pull Docker images from ghcr.io

@github-actions
Copy link

github-actions bot commented Jul 14, 2023

Staging application has been deployed and is available at: https://dash5-services.plotly.host/ml-exchange-staging
Production app name: ml-exchange
Current branch name: actions-for-spin-deployment
Commit: f851807

@Wiebke Wiebke requested a review from zhuowenzhao July 21, 2023 18:40
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. For .env instruction in README, please remove the quotes because docker-compose would parse the env variables as a string with the quotes.
  2. Please consider adding a "container_name: highres_seg_demo" to specify a customized container name (adopted on Vaughan).

@ndrezn
Copy link
Collaborator

ndrezn commented Jul 26, 2023

@Wiebke Wiebke requested a review from zhuowenzhao July 26, 2023 21:12
@danton267 danton267 merged commit 790b44c into main Jul 31, 2023
7 checks passed
@danton267 danton267 deleted the actions-for-spin-deployment branch July 31, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants