Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ keybinds #43

Merged
merged 23 commits into from
Aug 11, 2023
Merged

✨ keybinds #43

merged 23 commits into from
Aug 11, 2023

Conversation

danton267
Copy link
Collaborator

@danton267 danton267 commented Jul 14, 2023

Makes use of dash_extensions with a simple EventListener component defied do listen to keys (can listed to multiple events), and then used as a trigger for a callback where with a bit of extra logic you can write that if key X was pressed do something

@danton267 danton267 linked an issue Jul 14, 2023 that may be closed by this pull request
@danton267 danton267 self-assigned this Jul 14, 2023
@github-actions
Copy link

github-actions bot commented Jul 14, 2023

Staging application has been deployed and is available at: https://dash5-services.plotly.host/ml-exchange-staging
Production app name: ml-exchange
Current branch name: keybinds
Commit: c4ab9cc

Copy link
Collaborator

@hannahker hannahker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very cool 😎 Awesome work!

@hannahker
Copy link
Collaborator

Feel free to merge once merge conflicts have been resolved.

@danton267
Copy link
Collaborator Author

danton267 commented Aug 2, 2023

Add the following features:

  • classes 0-9 and ctrl+0-9 for the following 10 (up to 20 overall classes)
  • annotation tools - qwerty keys
  • notifications on tool/class changes
  • INFO button with all key binds / other info

@danton267 danton267 marked this pull request as draft August 2, 2023 12:59
@danton267
Copy link
Collaborator Author

danton267 commented Aug 3, 2023

  • allow key binds when the sidebar is closed
  • add notification on colour change
    • add the class name into notification

@danton267 danton267 requested a review from MinaMirz August 9, 2023 11:45
@danton267 danton267 marked this pull request as ready for review August 9, 2023 11:45
@danton267 danton267 changed the base branch from main to annotation-feature-revamp August 9, 2023 11:46
Base automatically changed from annotation-feature-revamp to main August 10, 2023 16:30
@tamidodo
Copy link
Contributor

tamidodo commented Aug 10, 2023

There's an extra line for the line annotation mode at the end of the annotation keybind instructions and a typo: "Keybding Shortcuts" instead of "Keybinding Shortcuts" otherwise looks good
Screenshot 2023-08-10 at 12 38 28 PM

Copy link
Contributor

@MinaMirz MinaMirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shift+[1-9] doesn't seem to work on Safari. Everything else was functional.

@danton267
Copy link
Collaborator Author

Had to remove alt keys/shift/ctrl because of issues with browser support and cross-compatibility between OS

  • ctrl is shared between win and mac but on windows browsers ctrl+1 changes to the first tab of the browser
  • alt/option is not shared
  • holding shift changes 123456789 to !"£$%^&*(

if this is requested in the future, we can ask for the browser header to determine what OS/browser user is using and tell app to listen/react to different keys

@danton267 danton267 merged commit 48f9267 into main Aug 11, 2023
4 checks passed
@danton267 danton267 deleted the keybinds branch August 11, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Look into hot key options
4 participants