Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add annotation buttons #31

Merged
merged 2 commits into from
Jul 12, 2023
Merged

add annotation buttons #31

merged 2 commits into from
Jul 12, 2023

Conversation

tamidodo
Copy link
Contributor

Closes #26

Adds buttons for freeform open/closed, circle, rectangle and "stop drawing" which switches it back to "pan" mode.

@github-actions
Copy link

github-actions bot commented Jul 12, 2023

Staging application has been deployed and is available at: https://dash5-services.plotly.host/ml-exchange-staging
Production app name: ml-exchange
Current branch name: custom-annotation-buttons
Commit: fb4d2ad

@hannahker
Copy link
Collaborator

Love it! Everything works well on my testing. Just have some UI change requests:

  • Can we make each button the same size and just display the icon, with the text in a tooltip? We should then be able to fit all 5 across in the same row, which would match vertically with the annotation classes below.
  • Can we have some visual indication for which button is currently selected? Maybe the background is coloured a slightly darker shade.
  • Let's have the "open freeform" option selected by default when the page loads.

Copy link
Collaborator

@hannahker hannahker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, LGTM 💃

@tamidodo tamidodo merged commit 4fd7c96 into main Jul 12, 2023
4 checks passed
@tamidodo tamidodo deleted the custom-annotation-buttons branch July 12, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create UI controls for annotation drawing modes
2 participants