Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding setup for Werkzeug profiling #22

Closed
wants to merge 5 commits into from
Closed

Adding setup for Werkzeug profiling #22

wants to merge 5 commits into from

Conversation

hannahker
Copy link
Collaborator

@hannahker hannahker commented Jul 10, 2023

These are temporary changes to set up a profiler for the Python code. See this blog post for more detailed instructions on running the profiler and interpreting the results: https://community.plotly.com/t/performance-profiling-dash-apps-with-werkzeug/65199 -- I really recommend using snakeviz as well to interpret results!

I have some WIP notes on profiling results here: https://docs.google.com/presentation/d/1c5_bJ8EUX5w2VCUFq0TEa3KepsdVsMPIboKt4ThIDO4/edit#slide=id.g28d4c0551f8_0_9

@github-actions
Copy link

github-actions bot commented Jul 10, 2023

Staging application has been deployed and is available at: https://dash5-services.plotly.host/ml-exchange-staging
Production app name: ml-exchange
Current branch name: profiling-dev
Commit: 27f8304

@hannahker hannahker requested a review from danton267 July 10, 2023 23:43
@ndrezn
Copy link
Collaborator

ndrezn commented Jul 12, 2023

@hannahker I might be able to help abstract this with dekn-client.

@danton267
Copy link
Collaborator

PR looks good.
Do we want to merge it or:

  • keep it as a separate "profiling" branch for now (so that we don't bloat the app with dev stuff)
  • wait for Nathan's package (or wait for it to be integrated into Dash)

I will add some more profiling report into the docs tomorrow

@hannahker
Copy link
Collaborator Author

Yeah, I don't think we want to merge this into the main branch. I think we can close for now and revisit if we need to do more profiling in the future.

@hannahker hannahker closed this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants