-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added automatic dash gui generator using dash-component-editor #171
Conversation
app.py
Outdated
], | ||
) | ||
|
||
### automatic Dash gui callback ### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this in app and not in something in callbacks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, why is this a callback and not a function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of questions
I am confused about the " test-and-lint" failures. Not sure what is wrong with the way importing libs. |
The test-and-lint action checks whether applying any of the pre-commit hooks would lead to changes. In this case, But don not worry about it, I'll work further on this PR. |
From there, it cannot reference the variable `app`, but we likely do not need this and the callback can become just a function so we will deal with this later.
E711 comparison to None should be 'if cond is None:' E265 block comment should start with '# ' F401 Unused import
e8545bd
to
2c6a4b5
Compare
Additionally pretty-prints model file for easier editing
The latest updates simplify some of the structure for generating components, use subclassing to the already existing control component already in the application, and remove some code that was either not used or could be called in a simpler way elsewhere. Two outstanding smaller issues are:
|
`Annotations` takes the image shape rather then the full `global_store` as input since mlexchange#171
Added model selection dropdown and fully integrated dash-component-editor into the interface.