Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added automatic dash gui generator using dash-component-editor #171

Merged
merged 22 commits into from
Mar 7, 2024

Conversation

zhuowenzhao
Copy link
Member

Added model selection dropdown and fully integrated dash-component-editor into the interface.

app.py Outdated
],
)

### automatic Dash gui callback ###
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this in app and not in something in callbacks?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, why is this a callback and not a function?

Copy link
Member

@dylanmcreynolds dylanmcreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of questions

@zhuowenzhao
Copy link
Member Author

I am confused about the " test-and-lint" failures. Not sure what is wrong with the way importing libs.

@Wiebke
Copy link
Member

Wiebke commented Mar 4, 2024

The test-and-lint action checks whether applying any of the pre-commit hooks would lead to changes. In this case, isort changes some of the orders in the model imports, later black and flake8 would give errors too.

But don not worry about it, I'll work further on this PR.

From there, it cannot reference the variable `app`, but we likely do not need this and the callback can become just a function so we will deal with this later.
E711 comparison to None should be 'if cond is None:'
E265 block comment should start with '# '
F401 Unused import
@Wiebke Wiebke requested a review from taxe10 March 6, 2024 22:11
@Wiebke
Copy link
Member

Wiebke commented Mar 6, 2024

The latest updates simplify some of the structure for generating components, use subclassing to the already existing control component already in the application, and remove some code that was either not used or could be called in a simpler way elsewhere.

Two outstanding smaller issues are:

  • We are not retaining common settings when switching between models
  • There is currently no space between components (fixable through either adding Space components or CSS style adaptions)

@taxe10 taxe10 merged commit 8de26f2 into main Mar 7, 2024
2 checks passed
@taxe10 taxe10 deleted the automatic-dash-component branch March 7, 2024 00:38
Wiebke added a commit to Wiebke/mlex_highres_segmentation that referenced this pull request Jun 26, 2024
`Annotations` takes the image shape rather then the full `global_store` as input since mlexchange#171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants