Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example tiled code #16

Merged
merged 5 commits into from
Jul 7, 2023
Merged

example tiled code #16

merged 5 commits into from
Jul 7, 2023

Conversation

dylanmcreynolds
Copy link
Member

Provides a sample notebook that shows how to communicate with the tiled server hosted for this project.

Also, splits requirements.txt files so that files used in development are in requirements-dev.txt

@dylanmcreynolds
Copy link
Member Author

I think the gh action failure is because I don't have the ssh key in my forked repo.

examples/requirements.txt Outdated Show resolved Hide resolved
examples/tiled.ipynb Show resolved Hide resolved
Copy link
Member

@Wiebke Wiebke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added commits resolving the previous comments.

@Wiebke
Copy link
Member

Wiebke commented Jul 7, 2023

@danton267 @tamidodo Could one of you take a look at the conflicts in requirements.txt?
Dylan split the file into two such that requirements-dev contains the packages needed only for development.
I would guess that
`gunicorn==20.1.0
requests==2.26.0'
would also better fit into requirements-dev.txt as you added these for deployment in f3989bc and 86d2759
Are there any others that are just for development?

@hannahker
Copy link
Collaborator

@Wiebke both gunicorn and requests should stay in the requirements.txt file. They're required for the deployment on Dash Enterprise and to download sample files from the GDrive, respectively. Looks good to move black and flake8 to requirements-dev.txt!

(We'll definitely remove any dependencies or files necessary for the Dash Enterprise deployment once we have the deployment set up on your infrastructure).

@Wiebke Wiebke merged commit 6f363fc into mlexchange:main Jul 7, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants