Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re drawing shapes after relayout event #147

Merged
merged 8 commits into from
Oct 18, 2023
Merged

re drawing shapes after relayout event #147

merged 8 commits into from
Oct 18, 2023

Conversation

cleaaum
Copy link
Collaborator

@cleaaum cleaaum commented Oct 12, 2023

This PR addresses the layer ordering of shapes. The first class should be the first layer, and the next ones should always be drawn on top. This wasn't always reflected when a user was drawing.
Also added a bugfix for the color change of a class that wasnt updating on every slice
Note: the only thing missing atm is the layering on a class color change. Open to suggestions on this !

@github-actions
Copy link

github-actions bot commented Oct 12, 2023

Staging application has been deployed and is available at: https://dash5-services.plotly.host/ml-exchange-staging
Production app name: ml-exchange
Current branch name: overlayShapes
Commit: 8c94203

@cleaaum cleaaum marked this pull request as ready for review October 13, 2023 14:31
@danton267
Copy link
Collaborator

works perfect! great work

@cleaaum cleaaum merged commit 2646491 into main Oct 18, 2023
4 checks passed
@cleaaum cleaaum deleted the overlayShapes branch October 18, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants