Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply isort #104

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Apply isort #104

merged 3 commits into from
Sep 12, 2023

Conversation

hannahker
Copy link
Collaborator

Minor quality of life enhancement to sort import statements throughout the codebase.

@github-actions
Copy link

github-actions bot commented Sep 12, 2023

Staging application has been deployed and is available at: https://dash5-services.plotly.host/ml-exchange-staging
Production app name: ml-exchange
Current branch name: apply-isort
Commit: 697e5b6

@cleaaum
Copy link
Collaborator

cleaaum commented Sep 12, 2023

I love using isort!! I usually do this right before code hand off as it gets annoying to deal with the import conflicts. Is there a way to automatically use this like we use black? I've been wanting to integrate this for a while.

@hannahker
Copy link
Collaborator Author

I've added it to our test-and-lint GH action so we should see an error on any commits that don't conform. Should work well with black now and be enforced in the same way.

Copy link
Collaborator

@cleaaum cleaaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay sounds good!!

@hannahker hannahker merged commit 27aa0d3 into main Sep 12, 2023
7 checks passed
@hannahker hannahker deleted the apply-isort branch September 12, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants