Cloning Request so that it can be used for retry fetch #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloning request object and sending back in response or error of fetch so that it can be used for retry logic with request. Using existing request object for retry throws an error as body is already read and used so cloning it
mahidhar4
commented
Dec 9, 2022
| @@ -19,11 +19,14 @@ function interceptor(fetch, ...args) { | |||
| // Register fetch call | |||
| promise = promise.then(args => { | |||
| const request = new Request(...args); | |||
| const cloneRequest = request.clone(); | |||
| return fetch(request).then(response => { | |||
There was a problem hiding this comment.
If Adding this cloneRequest is not super cool let's do the following change at least
Suggested change
| return fetch(request).then(response => { | |
| return fetch(request.clone()).then(response => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloning request object and sending back in response or error of fetch so that it can be used for retry logic with request. Using existing request object for retry throws an error as body is already read and used so cloning it