Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the smoke test (except the benchmark runs) #547

Merged
merged 13 commits into from
Oct 1, 2024
Merged

Conversation

wpietri
Copy link
Contributor

@wpietri wpietri commented Oct 1, 2024

This fixes a number of smoke test issues, but disables the benchmark runs in the hopes that they'll be fixed by #509, after which they should be reenabled.

@wpietri wpietri requested a review from a team as a code owner October 1, 2024 17:45
Copy link

github-actions bot commented Oct 1, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@wpietri wpietri requested review from dhosterman and removed request for dhosterman October 1, 2024 19:23
Copy link
Collaborator

@dhosterman dhosterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Get outta here, email alerts!

Copy link
Contributor

@bkorycki bkorycki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@wpietri wpietri merged commit 70143fb into main Oct 1, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants