Add offline dialog #954
Merged
Add offline dialog #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Closed
…s in the widget tree
anhappdev
previously requested changes
Feb 2, 2025
anhappdev
reviewed
Feb 4, 2025
|
@farook-edev We still encounter cases where a downloaded file becomes corrupted, primarily due to connection drops. In such instances, the app should automatically delete the corrupted file. If you prefer, we can create another pull request for this feature. |
|
freedomtan
approved these changes
Feb 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Dialog for when an offline (not connected to the internet) user attempts to download resources, the error only occurs in case a SocketException is caught, any other exceptions are still unhandled.
This fixes #948