fix: resolve crash on Play Store version #894

anhappdev · 2024-06-22T02:59:55Z

Closes Test Android Play Store version #893

github-actions · 2024-06-22T03:00:06Z

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

mohitmundhragithub · 2024-06-24T05:37:40Z

@anhappdev do you want me to try out this version of the app from the playstore?

anhappdev · 2024-06-24T06:28:27Z

@anhappdev do you want me to try out this version of the app from the playstore?

Yes. Please.

mohitmundhragithub · 2024-06-24T08:37:44Z

@anhappdev do you want me to try out this version of the app from the playstore?

Yes. Please.

i see the play store version was updated on 18th June. Can you push the apk with these fixes as well to playstore?

anhappdev · 2024-06-24T10:50:05Z

@mohitmundhragithub Ok. Thanks for the feedback. Is the crash occurred on any Android devices with the QTI backend or only on the Galaxy S23?

mohitmundhragithub · 2024-06-24T10:59:21Z

I tried the apk on another device (Samsung galaxy tab s8+, SD8Gen1). It crashes there as well.

Sadly I am still unable to upload the device logs... but following up with IT team internally.

freedomtan · 2024-06-25T05:08:35Z

@anhappdev please add [email protected] for internal testing

mohitmundhragithub · 2024-06-28T03:47:01Z

Galaxy S23 Ultra.txt

Hi Anh,

Finally able to upload the logs. Can you please check?

anhappdev · 2024-07-02T03:21:31Z

Galaxy S23 Ultra.txt

Hi Anh,

Finally able to upload the logs. Can you please check?

It looks like the same issue we have here:
#859 (comment)

For this issue, I still cannot find a solution.

mohitmundhragithub · 2024-07-02T03:24:06Z

actually the symptom (final log) for failure is same. But the reason would be different. Seems like when uploading to playstore, the DSP access gets denied but not otherwise.

Seems like we are missing some checks when uploading to playstore?

freedomtan · 2024-07-02T05:11:42Z

Let's see if we can

aab (in the CI) -> apk
try to get technical support from Play Store?
@freedomtan to try on MTK devices (or Samsung devices).

freedomtan · 2024-07-02T09:22:56Z

Works on

MTK devices: both newer .dla and older TFLite Neuron Delegate work
Pixel 8 Pro: works

@AhmedTElthakeb and @Mostelk: please check if the Play Store apk works on Exynos devices.

anhappdev · 2024-07-06T04:33:47Z

I opened a support ticket on Google Play, but they don't provide support for this kind of issue. Here is their answer:

Thanks for reaching out to Google Play Technical Support.
Although I’m happy to answer any questions about managing your apps on the Google Play Console, our team isn’t trained to provide technical support for app development questions.

freedomtan · 2024-07-16T05:12:19Z

@AhmedTElthakeb will try to run the in Play Store one w/ SELinux disabled (if that works, we are almost sure that there is some kind of permission setting problem).

sonarqubecloud · 2024-07-22T04:04:07Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

anhappdev · 2024-07-22T10:03:16Z

I don't know if it makes a different, but I deployed the app to the closed testing channel.
Compared to the internal testing channel, a user still needs to be invited to join the testing program (so it's not public), but the app is reviewed by Google on every release, so I hope maybe the app will not be classified as "untrusted app" anymore.

@mohitmundhragithub @AhmedTElthakeb Can you please test the app (v4.1.0 (164)) again:
https://play.google.com/apps/testing/org.mlcommons.android.mlperfbench

mohitmundhragithub · 2024-07-22T10:55:36Z

I don't know if it makes a different, but I deployed the app to the closed testing channel. Compared to the internal testing channel, a user still needs to be invited to join the testing program (so it's not public), but the app is reviewed by Google on every release, so I hope maybe the app will not be classified as "untrusted app" anymore.

@mohitmundhragithub @AhmedTElthakeb Can you please test the app (v4.1.0 (164)) again: https://play.google.com/apps/testing/org.mlcommons.android.mlperfbench

didn't work on GS23Ultra.

freedomtan · 2024-08-27T05:42:32Z

on rooted device, adb shell then setenfoce 0, and adb shell setenforce 0 (meaning disabling all the permission checks by the SELinux). @mohitmundhragithub and @AhmedTElthakeb

mohitmundhragithub · 2024-10-24T09:41:28Z

I think I found one workaround for the issue.

For QTI backend, if we push few of the dependent libs to the "files" folder, instead of packing it in the apk's "lib" folder, then the issue gets resolved for qti backend.
I want to try it out for the app to be downloaded from the play store.

@anhappdev, i will push a change to this PR... can you please help to push the aab file to the playstore? i can test with that.

freedomtan · 2024-10-25T03:58:50Z

@mohitmundhragithub The link is in this comment: #893 (comment)

Please noted the “internaltest” in the url.

@mohitmundhragithub I am told the one from Play Store works on a Samsung S24+ (8 Gen 3 inside).

mohitmundhragithub · 2024-10-25T05:49:38Z

@mohitmundhragithub The link is in this comment: #893 (comment)
Please noted the “internaltest” in the url.

@mohitmundhragithub I am told the one from Play Store works on a Samsung S24+ (8 Gen 3 inside).

That's surprising. Not sure how that could happen. The apk when sideloaded should work fine, but not the app from play store.

mohitmundhragithub · 2024-10-25T06:16:27Z

@mohitmundhragithub The link is in this comment: #893 (comment)

Please noted the “internaltest” in the url.

Thanks a lot @anhappdev. This link worked fine. I am able to download the updated app now.

The workaround that i had worked fine. Now we need to have a proper fix for the same.
Basically, with Android SDK 29 and onwards, the app can't use few libs from the /data/.../mlperf/libs folder. Workaround is to have the lib file present in the /sdcard/Android/data/...mlperfbench/files folder.

My suggestion is,

Add a field in the backend settings, and list the required dependent library.
We need to host the required dependent library somewhere, which the app downloads and saves in "/sdcard/Android/data/org.mlcommons.android.mlperfbench/files".
The above path needs to be known to the backend. So, either we can have a fixed path or pass the dynamic download location path to the backend, so that the backend can use this path. For QTI backend, we set the env variable "ADSP_LIBRARY_PATH" to do this.

mohitmundhragithub · 2024-10-25T06:17:39Z

@mohitmundhragithub The link is in this comment: #893 (comment)
Please noted the “internaltest” in the url.

Thanks a lot @anhappdev. This link worked fine. I am able to download the updated app now.

The workaround that i had worked fine. Now we need to have a proper fix for the same. My suggestion is,

Add a field in the backend settings, and list the required dependent library.

We need to host the required dependent library somewhere, which the app downloads and saves in "/sdcard/Android/data/org.mlcommons.android.mlperfbench/files".

The above path needs to be known to the backend. So, either we can have a fixed path or pass the dynamic download location path to the backend, so that the backend can use this path. For QTI backend, we set the env variable "ADSP_LIBRARY_PATH" to do this.

NB: the other minSDK 30 issue also gets resolved with this workaround.

mohitmundhragithub · 2024-10-28T11:16:58Z

@anhappdev, @freedomtan I have pushed the changes to download the libs directory as listed in the backend setting. Can you please review once?
This is a potential fix for the play store issue as well as the minSDKVersion issue.

After this change, we will need a way to host the required .so files somewhere, either in github or somewhere else. The backends will need to update the required files in the settings (just like the model files).

sonarqubecloud · 2024-10-28T11:39:06Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

anhappdev · 2024-10-29T02:13:54Z

The workaround that i had worked fine. Now we need to have a proper fix for the same. Basically, with Android SDK 29 and onwards, the app can't use few libs from the /data/.../mlperf/libs folder. Workaround is to have the lib file present in the /sdcard/Android/data/...mlperfbench/files folder.

My suggestion is,

Add a field in the backend settings, and list the required dependent library.

We need to host the required dependent library somewhere, which the app downloads and saves in "/sdcard/Android/data/org.mlcommons.android.mlperfbench/files".

The above path needs to be known to the backend. So, either we can have a fixed path or pass the dynamic download location path to the backend, so that the backend can use this path. For QTI backend, we set the env variable "ADSP_LIBRARY_PATH" to do this.

Another solution is to download the libs in the build step and put them in the same place where the native libs are:

mobile_app_open/flutter/android/android.mk

Lines 50 to 65 in fad36c1

    
           flutter_android_libs_folder=flutter/android/app/src/main/jniLibs/arm64-v8a 
        
           .PHONY: flutter/android/libs/copy 
        
           flutter/android/libs/copy: 
        
           	rm -rf ${flutter_android_libs_folder} 
        
           	mkdir -p ${flutter_android_libs_folder} 
        
           	@# macos doesn't support --target-directory flag 
        
           	cp -f \ 
        
           		${backend_tflite_android_files} \ 
        
           		${backend_mediatek_android_files} \ 
        
           		${backend_pixel_android_files} \ 
        
           		${backend_qti_android_files} \ 
        
           		${backend_samsung_android_files} \ 
        
           		${BAZEL_LINKS_PREFIX}bin/flutter/cpp/flutter/libbackendbridge.so \ 
        
           		${flutter_android_libs_folder} 
        
           	@# macos doesn't support --recursive flag 
        
           	chmod -R 777 ${flutter_android_libs_folder}

More info at https://developer.android.com/ndk/guides/abis#am

freedomtan · 2024-10-29T05:43:28Z

The cause of this issue is that the App cannot access some of the .so libraries in devices (e.g., in either /system or /vendor partition).

Why this restriction: there is some kind of SELinux rule(s) which prevent libraries not listed in a white list to be accessed by an App from the Play Store.

@mohitmundhragithub's solution is to copy the libraries the app needs to the App's library directory. However, I think this is a hack.

Long term solution: fix the "whitelist".

debugging hint: ld debug options (Android specific) to get more verbose ld outputs (which may help find the libraries been accessed), @freedomtan to find the options from Android documentation site

mohitmundhragithub · 2024-10-29T06:00:57Z

The workaround that i had worked fine. Now we need to have a proper fix for the same. Basically, with Android SDK 29 and onwards, the app can't use few libs from the /data/.../mlperf/libs folder. Workaround is to have the lib file present in the /sdcard/Android/data/...mlperfbench/files folder.

My suggestion is,

Add a field in the backend settings, and list the required dependent library.

We need to host the required dependent library somewhere, which the app downloads and saves in "/sdcard/Android/data/org.mlcommons.android.mlperfbench/files".

The above path needs to be known to the backend. So, either we can have a fixed path or pass the dynamic download location path to the backend, so that the backend can use this path. For QTI backend, we set the env variable "ADSP_LIBRARY_PATH" to do this.

Another solution is to download the libs in the build step and put them in the same place where the native libs are:

mobile_app_open/flutter/android/android.mk

Lines 50 to 65 in fad36c1

flutter_android_libs_folder=flutter/android/app/src/main/jniLibs/arm64-v8a

.PHONY: flutter/android/libs/copy

flutter/android/libs/copy:

rm -rf ${flutter_android_libs_folder}

mkdir -p ${flutter_android_libs_folder}

@# macos doesn't support --target-directory flag

cp -f \

${backend_tflite_android_files} \

${backend_mediatek_android_files} \

${backend_pixel_android_files} \

${backend_qti_android_files} \

${backend_samsung_android_files} \

${BAZEL_LINKS_PREFIX}bin/flutter/cpp/flutter/libbackendbridge.so \

${flutter_android_libs_folder}

@# macos doesn't support --recursive flag

chmod -R 777 ${flutter_android_libs_folder}

More info at https://developer.android.com/ndk/guides/abis#am

we have already been doing this. all the .so files are already part of the libs/abi folder. It used to work till now. however from, sdk 29 and above, there is an additional W^X restrictions.

there are a few libs required to access npu (suffixed skel.so), which have become inaccessible, from android 29 onwards.

i think there is similar restrictions for samsung stack as well.

when we copy the libs to files folder, the app is able to access those. this change facilitates that.

if we can find a way to pack these libs during build time to the files folder, then we dont need to download them separately.

freedomtan · 2024-10-29T06:01:54Z

Debug library loading issues: see https://android.googlesource.com/platform/bionic/+/master/android-changes-for-ndk-developers.md#enable-logging-of-dlopen_dlsym-and-library-loading-errors-for-apps-available-for-api-level-26

anhappdev · 2024-10-29T10:59:39Z

we have already been doing this. all the .so files are already part of the libs/abi folder. It used to work till now. however from, sdk 29 and above, there is an additional W^X restrictions.

there are a few libs required to access npu (suffixed skel.so), which have become inaccessible, from android 29 onwards.

Really? Did you try copy the *skel.so file to ${flutter_android_libs_folder} and test the app. All *.so files in ${flutter_android_libs_folder} should be executable else the native backends would not work.

Updated: I just checked the unified APK and the *skel.so files really already there. It doesn't make sense that it not works.

Execution of files from the writable app home directory is a W^X violation. Apps should load only the binary code that's embedded within an app's APK file.

https://developer.android.com/about/versions/10/behavior-changes-10#execute-permission

anhappdev · 2024-10-29T11:37:53Z

Did we try to specify all the libs in the AndroidManifest.xml with either uses-native-library or uses-library tag?
I don't know if it works, but maybe it's worth a try.

anhappdev · 2024-10-29T13:12:22Z

Specify native libs with <uses-native-library> in AndroidManifest.xml #929

mohitmundhragithub · 2024-10-29T13:29:30Z

Did we try to specify all the libs in the AndroidManifest.xml with either uses-native-library or uses-library tag?
I don't know if it works, but maybe it's worth a try.

yes. already tried this earlier.
androidmanifest.xml is meant for accessing any libs present in system's lib folder.

mohitmundhragithub · 2024-10-29T13:30:45Z

Specify native libs with <uses-native-library> in AndroidManifest.xml #929

tried it. didnt work on galaxy s23 ultra.

mohitmundhragithub · 2024-10-29T13:33:17Z

there is a IPC involved when trying to invoke the skel files. may be thats resulting in this behaviour.

same issue is seen for both playstore version and for apps with minsdkversion >= 29

anhappdev · 2024-10-31T11:38:35Z

Ok. Let move on with @mohitmundhragithub's solution: let the app download the *.so files.
But I will do it a bit different. I will push some new commits later.

anhappdev · 2024-11-01T02:00:35Z

@mohitmundhragithub Did we try to set android:extractNativeLibs="true" in the AndroidManifest.xml?

Set android:extractNativeLibs="true" as in https://stackoverflow.com/a/64792194
Set android.bundle.enableUncompressedNativeLibs=false as in https://stackoverflow.com/a/56551499

mohitmundhragithub · 2024-11-01T06:52:38Z

@mohitmundhragithub Did we try to set android:extractNativeLibs="true" in the AndroidManifest.xml?

Set android:extractNativeLibs="true" as in https://stackoverflow.com/a/64792194

Set android.bundle.enableUncompressedNativeLibs=false as in https://stackoverflow.com/a/56551499

the apk uploaded to play store (252) using PR #893 seems to resolve the play store issue at least on Galaxy S23 ultra.
Would be worthwhile to check if this can resolve the minSDKVersion 29 issue as well or not.

anhappdev · 2024-11-01T08:20:17Z

Would be worthwhile to check if this can resolve the minSDKVersion 29 issue as well or not.

Yes. It also resolved the issue with QTI backend in the PR #859.

anhappdev · 2024-11-12T06:33:54Z

Closed in favor of fix: resolve crash due to permission denied on Android Play Store version #930

anhappdev requested a review from a team as a code owner June 22, 2024 02:59

anhappdev marked this pull request as draft June 22, 2024 03:18

This comment was marked as outdated.

Sign in to view

anhappdev added this to the v4.1 milestone Oct 22, 2024

anhappdev closed this Oct 24, 2024

anhappdev force-pushed the anh/debug-play-store-version branch from 72e6ba1 to fad36c1 Compare October 24, 2024 09:56

github-actions bot locked and limited conversation to collaborators Oct 24, 2024

mlcommons unlocked this conversation Oct 24, 2024

This comment was marked as outdated.

Sign in to view

Adding the changes to download the libs path

7c96bed

mohitmundhragithub dismissed their stale review via 7c96bed October 28, 2024 11:14

mohitmundhragithub self-requested a review October 28, 2024 11:15

mohitmundhragithub requested a review from a team October 28, 2024 11:19

This was referenced Nov 1, 2024

Specify native libs with <uses-native-library> in AndroidManifest.xml #929

Closed

Test Android Play Store version #893

Closed

anhappdev closed this Nov 12, 2024

anhappdev deleted the anh/debug-play-store-version branch November 12, 2024 06:34

github-actions bot locked and limited conversation to collaborators Nov 12, 2024

fix: resolve crash on Play Store version #894

fix: resolve crash on Play Store version #894

Conversation

anhappdev commented Jun 22, 2024 • edited Loading

github-actions bot commented Jun 22, 2024 • edited Loading

mohitmundhragithub commented Jun 24, 2024

anhappdev commented Jun 24, 2024

mohitmundhragithub commented Jun 24, 2024

This comment was marked as outdated.

This comment was marked as outdated.

anhappdev commented Jun 24, 2024

mohitmundhragithub commented Jun 24, 2024 • edited Loading

freedomtan commented Jun 25, 2024

mohitmundhragithub commented Jun 28, 2024

anhappdev commented Jul 2, 2024

mohitmundhragithub commented Jul 2, 2024 • edited Loading

freedomtan commented Jul 2, 2024 • edited Loading

freedomtan commented Jul 2, 2024

anhappdev commented Jul 6, 2024

freedomtan commented Jul 16, 2024

sonarqubecloud bot commented Jul 22, 2024

Quality Gate passed

anhappdev commented Jul 22, 2024

mohitmundhragithub commented Jul 22, 2024

freedomtan commented Aug 27, 2024

mohitmundhragithub commented Oct 24, 2024

This comment was marked as outdated.

This comment was marked as outdated.

freedomtan commented Oct 25, 2024

mohitmundhragithub commented Oct 25, 2024

mohitmundhragithub commented Oct 25, 2024 • edited Loading

mohitmundhragithub commented Oct 25, 2024

mohitmundhragithub commented Oct 28, 2024 • edited Loading

sonarqubecloud bot commented Oct 28, 2024

Quality Gate passed

anhappdev commented Oct 29, 2024

freedomtan commented Oct 29, 2024 • edited Loading

mohitmundhragithub commented Oct 29, 2024

freedomtan commented Oct 29, 2024

anhappdev commented Oct 29, 2024 • edited Loading

anhappdev commented Oct 29, 2024

anhappdev commented Oct 29, 2024 • edited Loading

mohitmundhragithub commented Oct 29, 2024 • edited Loading

mohitmundhragithub commented Oct 29, 2024 • edited Loading

mohitmundhragithub commented Oct 29, 2024

anhappdev commented Oct 31, 2024

anhappdev commented Nov 1, 2024 • edited Loading

mohitmundhragithub commented Nov 1, 2024

anhappdev commented Nov 1, 2024

anhappdev commented Nov 12, 2024

anhappdev commented Jun 22, 2024 •

edited

Loading

github-actions bot commented Jun 22, 2024 •

edited

Loading

mohitmundhragithub commented Jun 24, 2024 •

edited

Loading

mohitmundhragithub commented Jul 2, 2024 •

edited

Loading

freedomtan commented Jul 2, 2024 •

edited

Loading

mohitmundhragithub commented Oct 25, 2024 •

edited

Loading

mohitmundhragithub commented Oct 28, 2024 •

edited

Loading

freedomtan commented Oct 29, 2024 •

edited

Loading

anhappdev commented Oct 29, 2024 •

edited

Loading

anhappdev commented Oct 29, 2024 •

edited

Loading

mohitmundhragithub commented Oct 29, 2024 •

edited

Loading

mohitmundhragithub commented Oct 29, 2024 •

edited

Loading

anhappdev commented Nov 1, 2024 •

edited

Loading