Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate Flutter SDK from v3.7 to v3.19 #883

Merged
merged 18 commits into from
May 23, 2024
Merged

Conversation

anhappdev
Copy link
Collaborator

@anhappdev anhappdev commented May 18, 2024

If you already has an existing dev environment, you may need to do this:

  • Download Flutter SDK v3.19.6 from https://docs.flutter.dev/release/archive and update your FLUTTER_HOME env to the new version or update your IDE with the new SDK.
  • Update your JDK to v17 or newer
  • Run dart pub global activate protoc_plugin 21.1.2 to update protoc_plugin version
  • Run docker volume rm mlperf-formatter-pubcache mlperf-formatter-output to clear the cache for make docker/format
  • Run cd flutter/ios && rm Podfile.lock && pod install --repo-update if you develop for iOS

@anhappdev anhappdev requested a review from a team as a code owner May 18, 2024 09:49
Copy link

github-actions bot commented May 18, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@anhappdev anhappdev changed the title feat: update Flutter SDK from 3.7 to v3.19 chore: update Flutter SDK from 3.7 to v3.19 May 18, 2024
@anhappdev anhappdev marked this pull request as draft May 18, 2024 09:52
@anhappdev anhappdev changed the title chore: update Flutter SDK from 3.7 to v3.19 chore: migrate Flutter SDK from v3.7 to v3.19 May 18, 2024
@anhappdev anhappdev force-pushed the 876/update-flutter-sdk branch 2 times, most recently from acf680d to 9bde034 Compare May 19, 2024 08:09
@anhappdev anhappdev force-pushed the 876/update-flutter-sdk branch from edf6297 to f8904d2 Compare May 19, 2024 14:59
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@anhappdev anhappdev marked this pull request as ready for review May 20, 2024 02:59
Copy link
Contributor

@freedomtan freedomtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GMS (Google Mobile Services?) is not enabled by default on phones purchased in China. Some of them can enable GMS easily; some are really complicated. Does our APP work with a phone without GMS enabled.

@anhappdev anhappdev merged commit 7bd3fe0 into master May 23, 2024
24 checks passed
@anhappdev anhappdev deleted the 876/update-flutter-sdk branch May 23, 2024 08:02
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants