Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Firebase App Check #878

Merged
merged 6 commits into from
May 28, 2024
Merged

feat: add Firebase App Check #878

merged 6 commits into from
May 28, 2024

Conversation

anhappdev
Copy link
Collaborator

@anhappdev anhappdev requested a review from a team as a code owner May 6, 2024 05:44
@anhappdev anhappdev marked this pull request as draft May 6, 2024 05:45
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@anhappdev anhappdev force-pushed the 844/add-firebase-appcheck branch from 6e29da8 to c75b55b Compare May 28, 2024 00:28
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@anhappdev anhappdev marked this pull request as ready for review May 28, 2024 04:25
@anhappdev anhappdev marked this pull request as draft May 28, 2024 04:25
@anhappdev anhappdev marked this pull request as ready for review May 28, 2024 04:26
freedomtan
freedomtan approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@freedomtan freedomtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anhappdev anhappdev merged commit 9543977 into master May 28, 2024
22 checks passed
@anhappdev anhappdev deleted the 844/add-firebase-appcheck branch May 28, 2024 05:14
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@freedomtan freedomtan freedomtan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up Firebase App Check
2 participants
@anhappdev @freedomtan