chore: remove manage all file permission #745

anhappdev · 2023-07-04T06:47:16Z

Closes Check if we can get rid of manage all file permission #702

github-actions · 2023-07-04T06:47:29Z

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

freedomtan · 2023-07-11T03:02:57Z

this PR worked for MediaTek internal devices except imagenet accuracy. dunno why yet.

anhappdev · 2023-07-11T05:24:10Z

this PR worked for MediaTek internal devices except imagenet accuracy. dunno why yet.

Did you rename the file imagenet_val_full.txt to imagenet_val_full.txt.pseudo.png?

freedomtan · 2023-07-18T01:36:57Z

this PR worked for MediaTek internal devices except imagenet accuracy. dunno why yet.

Did you rename the file imagenet_val_full.txt to imagenet_val_full.txt.pseudo.png?

surely I did. For mobiledet + coco, it ran well.

I tried it on my Pixel 7a, the app also crashed. See the attached logcat log mobilenet_crash.txt

freedomtan · 2023-07-18T02:05:47Z

If I use only the first 1000 ILSVRC2012_val_000*.JPEG, it works

anhappdev · 2023-07-18T03:10:05Z

Looking at the crash log, I guess maybe an image file is corrupted.

freedomtan · 2023-07-18T05:03:43Z

Looking at the crash log, I guess maybe an image file is corrupted.

with binary search, it shows ILSVRC2012_val_00001644.JPEG is incompatible with Android Exif related functions.
I am not sure if it's corrupted. It displayed well on both Android (with File app) and macOS Preview.

07-18 09:27:20.497  3254  5045 W System.err: java.lang.NumberFormatException: For input string: "????"
07-18 09:27:20.498  3254  5045 W System.err:    at java.lang.Integer.parseInt(Integer.java:747)
07-18 09:27:20.498  3254  5045 W System.err:    at java.lang.Integer.parseInt(Integer.java:865)
07-18 09:27:20.498  3254  5045 W System.err:    at android.media.ExifInterface$ExifAttribute.getIntValue(ExifInterface.java:1010)
07-18 09:27:20.498  3254  5045 W System.err:    at android.media.ExifInterface.handleThumbnailFromJfif(ExifInterface.java:4328)
07-18 09:27:20.498  3254  5045 W System.err:    at android.media.ExifInterface.setThumbnailData(ExifInterface.java:4301)
07-18 09:27:20.498  3254  5045 W System.err:    at android.media.ExifInterface.loadAttributes(ExifInterface.java:2033)
07-18 09:27:20.498  3254  5045 W System.err:    at android.media.ExifInterface.<init>(ExifInterface.java:1568)
07-18 09:27:20.498  3254  5045 W System.err:    at com.android.providers.media.MediaProvider.getRedactionRanges(MediaProvider.java:9050)
07-18 09:27:20.498  3254  5045 W System.err:    at com.android.providers.media.MediaProvider.getRedactionRanges(MediaProvider.java:9023)
07-18 09:27:20.498  3254  5045 W System.err:    at com.android.providers.media.MediaProvider.getRedactionRangesForFuse(MediaProvider.java:9005)
07-18 09:27:20.498  3254  5045 W System.err:    at com.android.providers.media.MediaProvider.onFileOpenForFuse(MediaProvider.java:9260)

I stripped EXIF information from the ILSVRC2012_val_00001644.JPEG file with exiftool, https://exiftool.org

exiftool -EXIF=  ILSVRC2012_val_00001644.JPEG

and push it back to Android, then it went well.

I am not sure if there are other problematic ones.

freedomtan · 2023-07-18T05:20:50Z

@freedomtan to try to remove EXIF information from all the jpeg files which have EXIF to if we can finish reading all the 50, 000 imagenet validation files. < --- this doesn't look elegant.

How MS office apps work on Android (do they use all file permission?) @freedomtan

freedomtan · 2023-07-18T05:29:19Z

for a in *.JPEG
  do exiftool -EXIF=  $a
done

freedomtan · 2023-07-18T08:41:51Z

@freedomtan to try to remove EXIF information from all the jpeg files which have EXIF to if we can finish reading all the 50, 000 imagenet validation files. < --- this doesn't look elegant.

How MS office apps work on Android (do they use all file permission?) @freedomtan

Confirmed that

if I remove all the EXIF in jpeg files, I can get expected accuracy number on my Pixel 7a
MS 365 apps DO need the "all file permission"

sonarqubecloud · 2023-07-18T12:28:44Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

freedomtan · 2023-07-25T05:12:43Z

Let's try to see if we can get the apk accepted to Play Store with the "all file permission" option there. If that doesn't work, then we can to use this one.

anhappdev · 2024-06-03T10:28:31Z

The app is now accepted by Google for public testing at
https://play.google.com/store/apps/details?id=org.mlcommons.android.mlperfbench

freedomtan · 2024-06-05T22:22:47Z

@anhappdev I didn't realize it's in "public testing" now. Could we back to "internal testing" because we don't have the EULA fixed and all the backends tested.

anhappdev · 2024-06-05T23:15:42Z

@anhappdev I didn't realize it's in "public testing" now. Could we back to "internal testing" because we don't have the EULA fixed and all the backends tested.

Ok. Done.

mohitmundhragithub · 2024-06-06T10:54:48Z

I tried to run the app on my galaxy s23... but it crashes. Do we know of any known issues?

anhappdev · 2024-06-06T11:33:25Z

I tried to run the app on my galaxy s23... but it crashes. Do we know of any known issues?

Can you test both the

build 136 (compileSdkVersion 34) and
build 134 (compileSdkVersion 33)
The compileSdkVersion was changed from 33 to 34. Maybe that is the issue.

freedomtan · 2024-06-11T05:15:33Z

@mohitmundhragithub to test build 136 and build 134

…ll-file-permission

sonarqubecloud · 2024-06-12T05:00:09Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

mohitmundhragithub · 2024-06-13T06:51:48Z

Hi @anhappdev @freedomtan, I tried both build 134 and build 136 on my galaxy S23 ultra. Both of them are able to run the testcases just fine.

anhappdev · 2024-06-13T07:10:21Z

I tried to run the app on my galaxy s23... but it crashes. Do we know of any known issues?

@mohitmundhragithub Can you share the crash log?

mohitmundhragithub · 2024-06-17T05:47:06Z

I tried to run the app on my galaxy s23... but it crashes. Do we know of any known issues?

@mohitmundhragithub Can you share the crash log?

Looks like the app is not available in playstore anymore.

anhappdev · 2024-06-17T06:50:07Z

I tried to run the app on my galaxy s23... but it crashes. Do we know of any known issues?

@mohitmundhragithub Can you share the crash log?

Looks like the app is not available in playstore anymore.

@mohitmundhragithub Can you test the APK here in the CI?

mohitmundhragithub · 2024-06-17T08:01:35Z

I tried to run the app on my galaxy s23... but it crashes. Do we know of any known issues?

@mohitmundhragithub Can you share the crash log?

Looks like the app is not available in playstore anymore.

@mohitmundhragithub Can you test the APK here in the CI?

I tried this apk: https://github.com/mlcommons/mobile_app_open/actions/runs/9476794795/artifacts/1592456513

which i got from here (this PR's CI): https://github.com/mlcommons/mobile_app_open/actions/runs/9476794795/job/26110387649?pr=745

This also works fine.
Could play store put some restrictions which makes the app to fail?

anhappdev · 2024-06-17T15:51:26Z

Could play store put some restrictions which makes the app to fail?

I don’t know yet. But if the crash is not related to this PR. Let’s merge this, then we will have a new build in Play Store and we can test the Play Store build again.

mohitmundhragithub · 2024-06-18T04:56:14Z

Could play store put some restrictions which makes the app to fail?

I don’t know yet. But if the crash is not related to this PR. Let’s merge this, then we will have a new build in Play Store and we can test the Play Store build again.

I am fine with it.
does it work for everyone else as well?

anhappdev marked this pull request as ready for review July 4, 2023 07:52

anhappdev requested a review from a team as a code owner July 4, 2023 07:52

anhappdev marked this pull request as draft July 25, 2023 05:13

anhappdev added the meta:postponed label Jul 25, 2023

anhappdev added 5 commits May 28, 2024 13:15

Remove custom data folder setting

853d794

Show resolved path in error screen

0eba145

Remove MANAGE_EXTERNAL_STORAGE permission

cfa9ead

Remove package file_picker and permission_handler

9d5577e

Remove FLUTTER_CACHE_FOLDER and FLUTTER_DATA_FOLDER

0a6e2b7

anhappdev force-pushed the 702/remove-access-all-file-permission branch from b9e4e4b to 0a6e2b7 Compare May 28, 2024 08:02

anhappdev marked this pull request as ready for review May 28, 2024 11:30

anhappdev removed the meta:postponed label May 31, 2024

freedomtan mentioned this pull request Jun 11, 2024

Things to be done before public release to Google Play. #891

Open

4 tasks

Merge remote-tracking branch 'origin/master' into 702/remove-access-a…

0138f33

…ll-file-permission

freedomtan approved these changes Jun 18, 2024

View reviewed changes

anhappdev merged commit 09e4b41 into master Jun 18, 2024
22 checks passed

anhappdev deleted the 702/remove-access-all-file-permission branch June 18, 2024 05:08

github-actions bot locked and limited conversation to collaborators Jun 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove manage all file permission #745

chore: remove manage all file permission #745

anhappdev commented Jul 4, 2023 •

edited

Loading

github-actions bot commented Jul 4, 2023 •

edited

Loading

freedomtan commented Jul 11, 2023 •

edited

Loading

anhappdev commented Jul 11, 2023

freedomtan commented Jul 18, 2023

freedomtan commented Jul 18, 2023

anhappdev commented Jul 18, 2023 •

edited

Loading

freedomtan commented Jul 18, 2023

freedomtan commented Jul 18, 2023 •

edited

Loading

freedomtan commented Jul 18, 2023

freedomtan commented Jul 18, 2023

sonarqubecloud bot commented Jul 18, 2023

freedomtan commented Jul 25, 2023

anhappdev commented Jun 3, 2024

freedomtan commented Jun 5, 2024

anhappdev commented Jun 5, 2024

mohitmundhragithub commented Jun 6, 2024

anhappdev commented Jun 6, 2024 •

edited

Loading

freedomtan commented Jun 11, 2024

sonarqubecloud bot commented Jun 12, 2024

mohitmundhragithub commented Jun 13, 2024

anhappdev commented Jun 13, 2024

mohitmundhragithub commented Jun 17, 2024

anhappdev commented Jun 17, 2024 •

edited

Loading

mohitmundhragithub commented Jun 17, 2024 •

edited

Loading

anhappdev commented Jun 17, 2024

mohitmundhragithub commented Jun 18, 2024

chore: remove manage all file permission #745

chore: remove manage all file permission #745

Conversation

anhappdev commented Jul 4, 2023 • edited Loading

github-actions bot commented Jul 4, 2023 • edited Loading

freedomtan commented Jul 11, 2023 • edited Loading

anhappdev commented Jul 11, 2023

freedomtan commented Jul 18, 2023

freedomtan commented Jul 18, 2023

anhappdev commented Jul 18, 2023 • edited Loading

freedomtan commented Jul 18, 2023

freedomtan commented Jul 18, 2023 • edited Loading

freedomtan commented Jul 18, 2023

freedomtan commented Jul 18, 2023

sonarqubecloud bot commented Jul 18, 2023

freedomtan commented Jul 25, 2023

anhappdev commented Jun 3, 2024

freedomtan commented Jun 5, 2024

anhappdev commented Jun 5, 2024

mohitmundhragithub commented Jun 6, 2024

anhappdev commented Jun 6, 2024 • edited Loading

freedomtan commented Jun 11, 2024

sonarqubecloud bot commented Jun 12, 2024

Quality Gate passed

mohitmundhragithub commented Jun 13, 2024

anhappdev commented Jun 13, 2024

mohitmundhragithub commented Jun 17, 2024

anhappdev commented Jun 17, 2024 • edited Loading

mohitmundhragithub commented Jun 17, 2024 • edited Loading

anhappdev commented Jun 17, 2024

mohitmundhragithub commented Jun 18, 2024

anhappdev commented Jul 4, 2023 •

edited

Loading

github-actions bot commented Jul 4, 2023 •

edited

Loading

freedomtan commented Jul 11, 2023 •

edited

Loading

anhappdev commented Jul 18, 2023 •

edited

Loading

freedomtan commented Jul 18, 2023 •

edited

Loading

anhappdev commented Jun 6, 2024 •

edited

Loading

anhappdev commented Jun 17, 2024 •

edited

Loading

mohitmundhragithub commented Jun 17, 2024 •

edited

Loading