Replace boolean usage #357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
arjunsuresh
reviewed
Apr 9, 2025
| @@ -641,15 +641,15 @@ def preprocess(i): | |||
| run_config += f" --audio_buffer_num_lines={audio_buffer_num_lines}" | |||
|
|
|||
| use_fp8 = str(env.get('MLC_MLPERF_NVIDIA_HARNESS_USE_FP8', '')) | |||
| if use_fp8 and use_fp8.lower() not in ["no", "false", "0", ""]: | |||
| if use_fp8 and is_true(use_fp8): | |||
There was a problem hiding this comment.
Not is_false is not the same as is_true 🙂. That's the case for boolean values only. If a variable is unset, the behaviour is changing here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to issue #177