Handle local data. #420
Merged
Handle local data. #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
pierrot0
approved these changes
Dec 4, 2023
| elif file_type == FileTypes.PARQUET: | ||
| return pd.read_parquet(file) | ||
| df = pd.read_parquet(file) | ||
| else: | ||
| raise NotImplementedError() |
There was a problem hiding this comment.
Can we add a message, something like "File format XXX no supported"? That's less cryptic, and people know what to ask for.
There was a problem hiding this comment.
Done in another PR (1d2ccf9).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a warning when the local data does not exist.
Save the data locally.
Encoding formats are in a select box.
Download files in data/ for Titanic
Use python-magic to guess the file type.
Add info on RecordSets.
Allow to re-trigger the dataset generation.
Gamify the experience with a percentage of completion.