Save manually created resource in the config #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
marcenacp
approved these changes
Nov 21, 2023
editor/views/files.py
Outdated
| if not name or (needs_sha256 and not sha256): | ||
| # Some required fields are empty. | ||
| st.toast( | ||
| "Please, import either a local file, provide a download URL, or" |
There was a problem hiding this comment.
Is the error message relevant to the error? Please, fill in all required fields: ...?
There was a problem hiding this comment.
Modified the error message. Basically we show the error if neither uploaded file, nor URL, nor the form with the manual input is filled in so that we can actually add a Resource. Probably would be better to have a dedicated error message for each "option".
Also, do we want to maybe not clear the form if it wasn't handled successfully? This way if the user e.g. inputs name, description and clicks "Upload" we don't delete everything but they can just add the SHA256.
aidazolic
force-pushed
the
aidazolic/resources
branch
from
63e9eee to
b6dc78d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the functionality to save a manually created resource. The ability to add data to this resource (e.g.
Record Sets) will be added separately.See the demo here