-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup_audio #322
Merged
Merged
Setup_audio #322
Changes from 4 commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
ade26eb
This should make the validation process easier.
monke6942021 5faaf02
Validation will be easier now.
monke6942021 b84be69
Merge branch 'main' of https://github.com/mlcommons/croissant
monke6942021 82b0217
This will let croissant recognize AudioObjects
monke6942021 506bd0d
mini_CC_BY_SA dataset has been added
monke6942021 9861395
This should make the validation process easier.
monke6942021 50d78ac
mini_CC_BY_SA dataset has been added
monke6942021 369621d
mini_CC_BY_SA is now part of the non-hermetic tests
monke6942021 5723b3f
Now it takes input from a Google Drive
monke6942021 4b7150e
Many of the tests were failing because of librosa, so anything with i…
monke6942021 fafe57d
Hopefully this passes the pr test
monke6942021 30d2aca
The validation script CLAIMS that it works.
monke6942021 5f23744
Hopefully black[jupyter] helps
monke6942021 56a86e8
Now jupyter has been added before the original black. Let's see if th…
monke6942021 babbbc2
I can try resetting to see if the formatting test works.
monke6942021 8cd0e89
Changed treatment of AudioObject in field.py
monke6942021 7d22310
This version can load audio in field.py
monke6942021 363bac6
Merge branch 'main' into setup_audio
monke6942021 4e5f54e
Audio files have some level of usability now.
monke6942021 081c129
The exact dataset I worked with
monke6942021 5a88008
I got the audio support to work.
monke6942021 154ef14
This should be a good touch up to help with jpeg files too.
monke6942021 28116d8
This is a cheap shot option, but it might pass the unit tests.
monke6942021 f42626f
Removed URL because it's not being used.
monke6942021 7f94125
librosa is now in ththe correct alphabetical position.
monke6942021 7706916
This is a gamble.
monke6942021 7fdc4b8
This is another gamble.
monke6942021 e4011ea
Changed import method for librosa.
monke6942021 8be8b76
I changed the pyptoject file. Let's see if it helps.
monke6942021 dcc8e01
Commented out the librosa import.
monke6942021 e9121b2
Hope this passes PyTest
monke6942021 8924b08
Installing black[jupyter]
monke6942021 2e24289
Storing black[jupyter] as a dependency.
monke6942021 5a441e8
black formatted some files.
monke6942021 12a0fd2
Another file has been black reformatted
monke6942021 578127e
I ran the test locally, and changed the file accordingly. I hope it w…
monke6942021 bec4b4f
I deleted the obvious error.
monke6942021 2dd38a7
Changed format of output.
monke6942021 ffb126d
Changed output to string format.
monke6942021 ca6db64
I just changed the test case, so this is a huge gamble.
monke6942021 24ffa9f
Pytest wants the data to be in double quotations.
monke6942021 4d48a9a
The output in records.jsonl and the output of the actual function are…
monke6942021 6777a07
The output file is going to be very long. I don't see any other way t…
monke6942021 b70229e
I forgot to save the output.
monke6942021 5c0eaed
Changed the number. Let's see if it works.
monke6942021 2a69efd
Mentioned that the package name is also librosa.
monke6942021 ab23572
Hope this works.
monke6942021 cf043c8
updated dev dependencies.
monke6942021 fd5393a
I used black in a different way, so it might work this time.
monke6942021 4c40d91
addressing the issues that Pierre bought up.
monke6942021 230d1fd
Since I used load.py for this one, I'm confident that this should work.
monke6942021 ba72b11
Changed the name of the library
monke6942021 0177150
removed the commment
monke6942021 9f2d083
dealt with conflicts.
monke6942021 c5d38e2
Hopefully I don't need git LFS for this.
monke6942021 b587614
black reformatted optional.py
monke6942021 1834c49
For some reason, my unit test is supposed to be in 0.8
monke6942021 7611a5a
Removed audio_test from 0.8.
monke6942021 c66524b
Added fileObject and fileSet in context.
monke6942021 a777c7f
I will remove this from 0.8 later, but I need to prove a point.
monke6942021 8b9b511
Adding audio_test to 0.8 did nothing of value.
monke6942021 b34ede7
Merge branch 'main' of https://github.com/mlcommons/croissant into se…
monke6942021 c0ce931
Changed audio_test to be compatible with new changes.
monke6942021 63603e4
This should pass the tests, but validation still works a bit differen…
monke6942021 d212703
They needed a version of the audio dataset in 0.8
monke6942021 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
absl-py==1.4.0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't use requirements.txt, but |
||
certifi==2023.7.22 | ||
charset-normalizer==3.2.0 | ||
decorator==5.1.1 | ||
etils==1.4.1 | ||
idna==3.4 | ||
importlib-resources==6.0.1 | ||
isodate==0.6.1 | ||
jsonpath-rw==1.4.0 | ||
networkx==3.1 | ||
numpy==1.25.2 | ||
pandas==2.1.0 | ||
pip==22.0.2 | ||
ply==3.11 | ||
pygraphviz==1.11 | ||
pyparsing==3.1.1 | ||
python-dateutil==2.8.2 | ||
pytz==2023.3.post1 | ||
rdflib==7.0.0 | ||
requests==2.31.0 | ||
setuptools==59.6.0 | ||
six==1.16.0 | ||
toml==0.10.2 | ||
tqdm==4.66.1 | ||
typing_extensions==4.7.1 | ||
tzdata==2023.3 | ||
urllib3==2.0.4 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this has changed. Can you rebase to have a freshest version of the code?