-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add log file parameter to cli commands #912
Merged
sarthakpati
merged 12 commits into
mlcommons:master
from
benmalef:add_logging_parameter_to_CLI_commands
Aug 20, 2024
Merged
Add log file parameter to cli commands #912
sarthakpati
merged 12 commits into
mlcommons:master
from
benmalef:add_logging_parameter_to_CLI_commands
Aug 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
benmalef
changed the title
Add --log-file parameter to cli commands
Add log-file parameter to cli commands
Aug 5, 2024
benmalef
changed the title
Add log-file parameter to cli commands
Add log file parameter to cli commands
Aug 5, 2024
sarthakpati
requested changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change requested. Also, I would suggest to add another point in the PR template:
- [ ] The `logging` library is being used and no `print` statements are left.
sarthakpati
approved these changes
Aug 19, 2024
sarthakpati
approved these changes
Aug 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
--log-file
parameter.Screenshots
If the user doesn't use the --log-file par, the logs will be saved in the
/tmp/.gandlf
dirIf the user uses the
--log-file
parameter.Checklist
CONTRIBUTING
guide has been followed.typing
is used to provide type hints, including and not limited to usingOptional
if a variable has a pre-defined value).pip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].