Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding second classification tutorial #698

Merged
merged 16 commits into from
Sep 7, 2023
Merged

Conversation

vavali08
Copy link
Contributor

Fixes #ISSUE_NUMBER

Proposed Changes

  • adds second classification tutorial that contains more detail

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sarthakpati
Copy link
Collaborator

Thanks for the PR, @vavali08!

2 major points before I proceed with a review:

  • Could you please ensure you are using the latest version of GaNDLF? The current tag is 0.0.16, and it seems like your tutorial is using 0.0.14.
  • Can you put your tutorial in a separate folder, the way the classification_medmnist_notebook is present?

@vavali08
Copy link
Contributor Author

Hi, I just changed the file and put it into a folder. Please let me know if the other files (config.yaml etc) also should be put into the folder or if I should rename anything. Thanks!

@sarthakpati
Copy link
Collaborator

sarthakpati commented Jul 28, 2023

Hey, a few notes:

  • git clone -b 0.0.16 --depth 1 https://github.com/CBICA/GaNDLF.git should probably change to pip install gandlf
  • The config should be included in the folder.
  • The folder name needs to be more descriptive - perhaps classification_pathmnist_notebook?

@sarthakpati
Copy link
Collaborator

Apologies, but due to an unforeseen issue, OpenFL tests are failing [ref]. Please hang on tight while we are coordinating a fix, and we will re-initiate the failing run automatically.

@vavali08
Copy link
Contributor Author

Got it, I just modified the files as per your previous suggestions.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #698 (2e8bb00) into master (72eb99f) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 2e8bb00 differs from pull request most recent head c17a4d5. Consider uploading reports for the commit c17a4d5 to get more accurate results

@@            Coverage Diff             @@
##           master     #698      +/-   ##
==========================================
+ Coverage   94.71%   94.72%   +0.01%     
==========================================
  Files         117      117              
  Lines        8253     8251       -2     
==========================================
- Hits         7817     7816       -1     
+ Misses        436      435       -1     
Flag Coverage Δ
unittests 94.72% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarthakpati sarthakpati merged commit d743d9c into mlcommons:master Sep 7, 2023
14 of 15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants