[Feature] Update apply mask kernels #128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the apply mask kernel computes:
This means the shape of the bitmask is
(len(indices), bitmask_size)
, wherelen(indices)
represents the number of structured generation requests in a batch. However, this number can be different for different batches, and the shape of the bitmask also differs.This PR makes the shape of the bitmask consist across batches to make it easier to allocate the bitmask. It fixes the shape of the bitmask to (batch_size, bitmask_size), and modifies the apply mask kernel to:
GPU Kernel benchmarks:
It also removes CUDA kernel impl.