Set MLCEngineConfig.logLevel optional in config.ts
#439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neet-Nestor
approved these changes
May 31, 2024
|
Thank you! |
CharlieFRuan
added a commit
that referenced
this pull request
May 31, 2024
### Changes This patch contains various small fixes: - Allow `log` from `engine.ts` and `llm_chat.ts`, etc. to show in service and web worker - e720f2a - Fix `index.js.map` issue for Vite - #440 - Make `MLCEngineConfig.logLevel` optional - #439 ### TVMjs No change, TVMjs compiled at apache/tvm@71f7af7 ### WASM version - No change -- 0.2.39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #427 to prevent the following type issue introduced on
v0.2.39:This issue fails type-checking [reference] and forces users to define the
logLevelconfig.But in fact,
logLevelalready has a default value and was intended to be an optional parameter.This PR fixes it.