Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Style] Add GitHub action for linter and pre-commit hook formater #412

Merged
merged 1 commit into from
May 22, 2024
Merged

[Style] Add GitHub action for linter and pre-commit hook formater #412

merged 1 commit into from
May 22, 2024

Conversation

Neet-Nestor
Copy link
Contributor

@Neet-Nestor Neet-Nestor commented May 22, 2024

Overview

Currently this repo doesn't have a formatter setup. Besides, even though we have ESLint rule set up, these rules are not currently enforced in this repo.

This PR adds the following to ensure better code quality:

  • Add prettier for code auto formatting
  • Run prettier format on every commit using pre-commit hook using husky
  • Add GitHub actions for automatically checks ESLint and Prettier on PRs and pushes

All other changes are just auto formatting and can be safely ignored.

Testing

Pre-commit hooks:

 git commit -m "[Style] Add GitHub action for linter and pre-commit hook formater"   

✔ Preparing lint-staged...
✔ Running tasks for staged files...
✔ Applying modifications from tasks...
✔ Cleaning up temporary files...

@Neet-Nestor Neet-Nestor changed the title [Style] Add GitHub action for linter and pre-commit hook for formating [Style] Add GitHub action for linter and pre-commit hook formater May 22, 2024
@tqchen tqchen merged commit d7fe670 into mlc-ai:main May 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants