-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Django 3.0 #80
base: master
Are you sure you want to change the base?
Conversation
I appreciate this effort and it would be great to see this project working on the latest Django (though as you can probably tell I don't really use this very much anymore). But I can't justify merging this while the test suite is broken. |
de0dde7
to
55e6d2d
Compare
My apologies, I had already fixed the tests for the most recent Django version, but hadn't updated the tox and travis configuration files. The test suite is now fixed. |
@@ -13,31 +13,29 @@ def read_file(filename): | |||
|
|||
|
|||
setup( | |||
name='django-all-access', | |||
name='django3-all-access', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are obviously welcome to publish your own version of this package under the terms of the BSD license but that shouldn't be part of this PR.
For those coming to this later. The new project from @juliorkm is |
Brian! I'm doing well (all things considered). Sadly I don't really use Django much anymore, in case that wasn't already obvious from my inactivity here. If @juliorkm or you want to take over this project I'm happy to get you access to the PyPi repository and Read the Docs ❤️ |
django-all-access unfortunately only supports Django 1. Many projects have difficulty upgrading to newer Django versions due to this dependency. This pull request makes this project work on Django 3.0, but due to Django's lack of backward compatibility, removes the ability to use it on earlier versions.