Skip to content

Updated docs/haskell.md and docs/purescript.md to reflect the updated frontend tools #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

jaredponn
Copy link
Collaborator

@jaredponn jaredponn commented Oct 25, 2023

A short PR to update the documentation to use the tools in #121. This also:

  • Changed the example to use lambda buffers prelude and hence use the opaque Char type (it won't compile otherwise without it)

@jaredponn jaredponn linked an issue Oct 25, 2023 that may be closed by this pull request
6 tasks
@jaredponn jaredponn mentioned this pull request Oct 25, 2023
6 tasks
@jaredponn jaredponn requested a review from bladyjoker October 25, 2023 01:05
@jaredponn jaredponn self-assigned this Oct 25, 2023
Copy link
Contributor

@bladyjoker bladyjoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, let's use Prelude for this:

That would change the schema for Document a bit...

module Document

-- We need the opaque Char type
import Prelude (Text, List, Set, Bytes)

-- Author
sum Author = Ivan | Jovan | Savo

-- Reviewer
sum Reviewer = Bob | Alice

-- Document
record Document a = {
  author : Author,
  reviewers : Set Reviewer,
  content : Chapter a
 }

-- Chapter
record Chapter a = {
  content : a,
  subChapters : List (Chapter a)
 }

-- Some actual content
sum RichContent = Image Bytes | Gif Bytes | Text Text

-- Rich document
prod RichDocument = (Document RichContent)

@jaredponn jaredponn requested a review from bladyjoker October 25, 2023 19:54
Copy link
Contributor

@bladyjoker bladyjoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jaredponn
Copy link
Collaborator Author

Thank you for the feedback! I'll rebase and merge this now.

@jaredponn jaredponn force-pushed the jared/114-leftovers-updating-docs branch from 7ddf57d to b56e1cf Compare October 26, 2023 19:02
@jaredponn jaredponn added this pull request to the merge queue Oct 26, 2023
Merged via the queue into main with commit 61df719 Oct 26, 2023
@jaredponn jaredponn deleted the jared/114-leftovers-updating-docs branch October 26, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Leftovers #114
2 participants