-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve notebook #44
Improve notebook #44
Changes from all commits
8ed0840
c498e96
fcdfad0
95e531a
df3b7bb
34be11b
9b240a6
bc469a7
39996df
603868d
e2170fd
79824aa
190cc15
f104c8d
f008eed
e201ad3
00d3c19
5385435
9386311
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ services: | |
weaviate: | ||
image: semitechnologies/weaviate:1.20.5 | ||
ports: | ||
- 8080:8080 | ||
- 8081:8080 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a reason for this change? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Port 8080 is occupied when using jupyter on vertex workbench |
||
environment: | ||
CONTEXTIONARY_URL: contextionary:9999 | ||
QUERY_DEFAULTS_LIMIT: 25 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This did not point to anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like I deleted it in this PR.
It might make sense to re-add it just for the indexing pipeline. WDYT?
If not, I would still add a link for the CLI to the documentation, and keep the link to the notebook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be best to go for the second approach since we don't have a file ready to launch the pipeline from (currently organized in a function that creates the pipeline). Updated