-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select-Case conversion for Fortran #422
Conversation
Codecov Report
@@ Coverage Diff @@
## master #422 +/- ##
=========================================
Coverage ? 73.42%
=========================================
Files ? 60
Lines ? 13635
Branches ? 0
=========================================
Hits ? 10011
Misses ? 3624
Partials ? 0
Continue to review full report at Codecov.
|
@pratikbhd I was thinking about the "Inf" placeholder used to normalize CASE labels. Suppose the program has a variable named Inf, as shown in the program below. Would that cause a name conflict in the translation?
|
@skdebray I realized that the regular expression in Now, the code above does not cause conflict in the translation because of the following reason:
However, I found a bug with using All the changed code is in the |
@pratikbhd Re: constants in case labels, we also need to be able to handle string and LOGICAL constants in case labels (e.g., see here). For example, the following code is from the file
|
@skdebray Strings are handled by CASE statements. I haven't extensively tested for them though. I also will have to test for LOGICAL constants. |
@pratikbhd Let's not worry about Can you create an issue for |
This PR implements the following changes: