Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce feature reducer and breaking down action and reducer concept #16

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

Arman-Morshed
Copy link
Contributor

Description

This PR contains the concept of breaking down Action into sub Actions (ViewAction, InternalAction, ChildAction, DelegateAction, DestinationActtion) and also breaking down reducer for each of the action in composable Architecture.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

All Submissions:

  • Does your code follows the Style Guidelines of this project?
  • Does your commit message follows the Conventional Commits?
  • Did you make sure your changes generate no new warnings?
  • Did you ensure new and existing unit tests pass locally with your changes?
  • Have you performed a self-review of my code?
  • Have you commented on your code, particularly in hard-to-understand areas?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you followed the guidelines in our Contributing Document?

New Feature Submissions:

  • Have you added tests that prove that your feature works?
  • Have you lint your code locally before submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?

Copy link
Collaborator

@rokon-uddin rokon-uddin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rokon-uddin rokon-uddin merged commit 642c30c into ml-opensource:main Dec 12, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants