Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix creating array from bf16 tensors in jax / torch #1305

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Fix creating array from bf16 tensors in jax / torch #1305

merged 1 commit into from
Aug 1, 2024

Conversation

awni
Copy link
Member

@awni awni commented Aug 1, 2024

Addresses part of #1296

This works now:

import mlx.core as mx
import jax.numpy as jnp
a = jnp.array([1.0,2.0], dtype=jnp.bfloat16)
b = mx.array(a)

angeloskath
angeloskath approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@angeloskath angeloskath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@awni awni merged commit 10b5835 into main Aug 1, 2024
3 checks passed
@awni awni deleted the fix_from_bf16 branch August 1, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angeloskath angeloskath angeloskath approved these changes

@barronalex barronalex Awaiting requested review from barronalex

@jagrit06 jagrit06 Awaiting requested review from jagrit06

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@awni @angeloskath