-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigating adding Windows support #236
Draft
ml-evs
wants to merge
11
commits into
master
Choose a base branch
from
ml-evs/add_windows_CI
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46580b8
to
1ffd72d
Compare
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
=======================================
Coverage 73.76% 73.76%
=======================================
Files 96 96
Lines 12912 12912
=======================================
Hits 9524 9524
Misses 3388 3388
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
325db27
to
bcd1ec7
Compare
b22bbc6
to
236a1f0
Compare
73a3377
to
b013ec5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #151 and #225.
Main tasks:
encoding="utf-8"
🥱setup(..., scripts=scripts, ...)
due to the file encoding, need to investigateI am not sure this is worth adding support for, especially as many of the dependencies of this package do not provide proper support for Windows, but the pathlib changes would make for some cleaner code anyway.