Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigating adding Windows support #236

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Conversation

ml-evs
Copy link
Owner

@ml-evs ml-evs commented Feb 4, 2022

re: #151 and #225.

Main tasks:

  • Any time we open a file, we should specify encoding="utf-8" 🥱
  • Any time we hardcode or manipulate a file path (which is a lot of places...), we should use pathlib...
  • Something is broken with setup(..., scripts=scripts, ...) due to the file encoding, need to investigate

I am not sure this is worth adding support for, especially as many of the dependencies of this package do not provide proper support for Windows, but the pathlib changes would make for some cleaner code anyway.

@ml-evs ml-evs force-pushed the ml-evs/add_windows_CI branch 3 times, most recently from 46580b8 to 1ffd72d Compare February 5, 2022 15:44
@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #236 (b013ec5) into master (26c7688) will not change coverage.
The diff coverage is 52.63%.

@@           Coverage Diff           @@
##           master     #236   +/-   ##
=======================================
  Coverage   73.76%   73.76%           
=======================================
  Files          96       96           
  Lines       12912    12912           
=======================================
  Hits         9524     9524           
  Misses       3388     3388           
Flag Coverage Δ
unittests 73.76% <52.63%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
matador/battery/electrode.py 86.79% <0.00%> (ø)
matador/compute/compute.py 44.11% <0.00%> (ø)
matador/hull/hull.py 90.24% <0.00%> (ø)
matador/utils/castep_help_utils.py 0.00% <0.00%> (ø)
matador/utils/pmg_utils.py 30.23% <0.00%> (ø)
matador/utils/viz_utils.py 11.32% <50.00%> (ø)
matador/export/export.py 70.76% <71.42%> (ø)
matador/config/config.py 82.45% <100.00%> (ø)
matador/db/refine.py 66.66% <100.00%> (ø)
matador/export/utils.py 92.15% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ml-evs ml-evs force-pushed the ml-evs/add_windows_CI branch 2 times, most recently from 325db27 to bcd1ec7 Compare February 5, 2022 19:54
@ml-evs ml-evs changed the title Add Windows CI run Investigating adding Windows support Feb 6, 2022
@ml-evs ml-evs force-pushed the ml-evs/add_windows_CI branch from b22bbc6 to 236a1f0 Compare August 23, 2022 16:21
@ml-evs ml-evs force-pushed the ml-evs/add_windows_CI branch from 73a3377 to b013ec5 Compare August 23, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant